Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8182)

Unified Diff: base/BUILD.gn

Issue 2702463003: NativeStackSampler implementation for Mac. (Closed)
Patch Set: fix config Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index f84856de5c9533650e0ec78203c0694ac0ba38a1..8ed1aa142b9f66484d6af4a7bc45ad7dd8db5d07 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -719,6 +719,7 @@ component("base") {
"process/process_win.cc",
"profiler/native_stack_sampler.cc",
"profiler/native_stack_sampler.h",
+ "profiler/native_stack_sampler_mac.cc",
"profiler/native_stack_sampler_posix.cc",
"profiler/native_stack_sampler_win.cc",
"profiler/scoped_profile.cc",
@@ -1458,6 +1459,10 @@ component("base") {
"strings/sys_string_conversions_posix.cc",
"threading/platform_thread_internal_posix.cc",
]
+
+ if (is_mac) {
+ sources -= [ "profiler/native_stack_sampler_posix.cc" ]
+ }
} else {
# Non-Mac/ios.
sources -= [
@@ -1829,7 +1834,9 @@ if (is_win) {
"//base/win:base_win_features",
]
}
+}
+if (is_win || is_mac) {
if (current_cpu == "x64") {
# Must be a shared library so that it can be unloaded during testing.
shared_library("base_profiler_test_support_library") {
@@ -2285,6 +2292,9 @@ test("base_unittests") {
"CoreFoundation.framework",
"Foundation.framework",
]
+ if (current_cpu == "x64") {
+ data_deps += [ ":base_profiler_test_support_library" ]
+ }
}
if (is_linux) {
@@ -2323,7 +2333,7 @@ test("base_unittests") {
deps += [ "//base:scoped_handle_test_dll" ]
if (current_cpu == "x64") {
sources += [ "profiler/win32_stack_frame_unwinder_unittest.cc" ]
- deps += [ ":base_profiler_test_support_library" ]
+ data_deps += [ ":base_profiler_test_support_library" ]
}
}
« no previous file with comments | « no previous file | base/profiler/native_stack_sampler_mac.cc » ('j') | chrome/common/stack_sampling_configuration.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698