NativeStackSampler implementation for Mac.

chrome/common/stack_sampling_configuration.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/stack_sampling_configuration.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/rand_util.h"
+#include "build/build_config.h"
 #include "chrome/common/channel_info.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/version_info/version_info.h"
 #include "content/public/common/content_switches.h"
 
 namespace {
 
 base::LazyInstance<StackSamplingConfiguration>::Leaky g_configuration =
     LAZY_INSTANCE_INITIALIZER;
 
-// The profiler is currently only implemented for Windows x64, and only runs on
-// trunk, canary, and dev.
+// The profiler is currently only implemented for Windows x64 and Mac x64.
 bool IsProfilerSupported() {
-#if !defined(_WIN64)
+#if defined(OS_WIN)

[Mike Wittman, 2017/03/27 19:48:46]

#if defined(OS_WIN) && defined(ARCH_CPU_X86_64)

[Avi (use Gerrit), 2017/03/29 17:52:09]

Done.

+  // Only run on trunk, canary, and dev.
+  const version_info::Channel channel = chrome::GetChannel();

[Mike Wittman, 2017/03/27 19:48:46]

Can we do this so we have the same approach wrt the unknown channel:

#if defined(GOOGLE_CHROME_BUILD)
const version_info::Channel channel = chrome::GetChannel();
return channel == version_info::Channel::CANARY ||
    channel == version_info::Channel::DEV;
#else
return true;
#endif

[Avi (use Gerrit), 2017/03/29 17:52:09]

Done.

+  return channel == version_info::Channel::UNKNOWN ||
+         channel == version_info::Channel::CANARY ||
+         channel == version_info::Channel::DEV;
+#elif defined(OS_MACOSX)
+  // This is experimental, so only run on trunk.
+  #if defined(GOOGLE_CHROME_BUILD)

[Mike Wittman, 2017/03/20 19:21:30]

Can you apply the same change to the OS_WIN section, for consistency?

[Avi (use Gerrit), 2017/03/27 16:06:30]

Done.

+    return false;
+  #else
+    return true;
+  #endif
+#else
   return false;
-#else
-  const version_info::Channel channel = chrome::GetChannel();
-  return (channel == version_info::Channel::UNKNOWN ||
-          channel == version_info::Channel::CANARY ||
-          channel == version_info::Channel::DEV);
 #endif
 }
 
 // Returns true if the current execution is taking place in the browser process.
 bool IsBrowserProcess() {
   const base::CommandLine* command_line =
       base::CommandLine::ForCurrentProcess();
   std::string process_type =
       command_line->GetSwitchValueASCII(switches::kProcessType);
   return process_type.empty();
@@ skipping 152 matching lines @@
         { PROFILE_GPU_PROCESS, 0},
         { PROFILE_BROWSER_AND_GPU_PROCESS, 80},
         { PROFILE_CONTROL, 10},
         { PROFILE_DISABLED, 10}
       });
 
     default:
       return PROFILE_DISABLED;
   }
 }