Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 270243002: Update extensions_resources to use grit_target.gypi. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Cook
Visibility:
Public.

Description

Update extensions_resources to use grit_target.gypi. This is just a small cleanup while I'm here and for being consistent with other files of the same nature. BUG=None TEST=extensions_unittests R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M extensions/extensions_resources.gyp View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 7 months ago (2014-05-07 03:38:09 UTC) #1
Yoyo Zhou
LGTM
6 years, 7 months ago (2014-05-07 20:07:55 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 7 months ago (2014-05-07 20:07:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270243002/1
6 years, 7 months ago (2014-05-07 20:15:24 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 21:38:47 UTC) #5
Message was sent while issue was closed.
Change committed as 268962

Powered by Google App Engine
This is Rietveld 408576698