Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2687)

Unified Diff: ash/public/cpp/shelf_types.h

Issue 2702423004: Validate incoming window properties. (Closed)
Patch Set: sky comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/public/cpp/shelf_types.h
diff --git a/ash/public/cpp/shelf_types.h b/ash/public/cpp/shelf_types.h
index 607419929edf2482ce9d7914b214e1af40b1fa17..8f1581db52be5fc090bf393f6c2dbe8a1d4a97ff 100644
--- a/ash/public/cpp/shelf_types.h
+++ b/ash/public/cpp/shelf_types.h
@@ -5,6 +5,10 @@
#ifndef ASH_PUBLIC_CPP_SHELF_TYPES_H_
#define ASH_PUBLIC_CPP_SHELF_TYPES_H_
+#include <cstdint>
+
+#include "ash/public/cpp/ash_public_export.h"
+
namespace ash {
enum ShelfAlignment {
@@ -114,6 +118,9 @@ enum ShelfItemType {
TYPE_UNDEFINED,
};
+// Returns true if |i| is a valid ShelfItemType.
+ASH_PUBLIC_EXPORT bool IsValidShelfItemType(int64_t i);
msw 2017/02/23 22:35:11 optional nit: |i| -> |type| or |value| (in comment
Elliot Glaysher 2017/02/23 22:57:34 Done.
+
// Represents the status of applications in the shelf.
enum ShelfItemStatus {
// A closed shelf item, i.e. has no live instance.

Powered by Google App Engine
This is Rietveld 408576698