Validate incoming window properties.

ash/public/cpp/shelf_types.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_PUBLIC_CPP_SHELF_TYPES_H_
 #define ASH_PUBLIC_CPP_SHELF_TYPES_H_
 
+#include <cstdint>
+
+#include "ash/public/cpp/ash_public_export.h"
+#include "base/callback_forward.h"
+
 namespace ash {
 
 enum ShelfAlignment {
   SHELF_ALIGNMENT_BOTTOM,
   SHELF_ALIGNMENT_LEFT,
   SHELF_ALIGNMENT_RIGHT,
   // Top has never been supported.
 
   // The locked alignment is set temporarily and not saved to preferences.
   SHELF_ALIGNMENT_BOTTOM_LOCKED,
@@ skipping 89 matching lines @@
   //                    ARC (App Runtime for Chrome - Android Play Store) apps.
   TYPE_APP,
 
   // Represents a dialog.
   TYPE_DIALOG,
 
   // Default value.
   TYPE_UNDEFINED,
 };
 
+// Returns a callback which will return true if the value passed to it is a
+// valid ShelfItemType value.
+ASH_PUBLIC_EXPORT base::RepeatingCallback<bool(int32_t)>

[sky, 2017/02/23 21:02:25]

Why expose a callback here? I certainly get wanting a function like
IsValidShelfItemType(int32_t), but whether that's done using a callback seems
like something the consumers of this function should do.

[Elliot Glaysher, 2017/02/23 22:12:42]

Done.

+ValidateShelfItemType();
+
 // Represents the status of applications in the shelf.
 enum ShelfItemStatus {
   // A closed shelf item, i.e. has no live instance.
   STATUS_CLOSED,
   // A shelf item that has live instance.
   STATUS_RUNNING,
   // An active shelf item that has focus.
   STATUS_ACTIVE,
   // A shelf item that needs user's attention.
   STATUS_ATTENTION,
 };
 
 }  // namespace ash
 
 #endif  // ASH_PUBLIC_CPP_SHELF_TYPES_H_