Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Unified Diff: chrome/browser/ui/views/harmony/layout_delegate.cc

Issue 2702403010: Fix the absence of padding on some UI buttons. (Closed)
Patch Set: change switch Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/harmony/layout_delegate.h ('k') | ui/views/controls/button/md_text_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/harmony/layout_delegate.cc
diff --git a/chrome/browser/ui/views/harmony/layout_delegate.cc b/chrome/browser/ui/views/harmony/layout_delegate.cc
index d366297d1520fffbeb0db5a3fd029cdd8165bb85..1f80b8776d9492dc62e1618e34ede4c13608d15f 100644
--- a/chrome/browser/ui/views/harmony/layout_delegate.cc
+++ b/chrome/browser/ui/views/harmony/layout_delegate.cc
@@ -23,7 +23,9 @@ LayoutDelegate* LayoutDelegate::Get() {
int LayoutDelegate::GetMetric(Metric metric) const {
switch (metric) {
case Metric::BUTTON_HORIZONTAL_PADDING:
- return 0;
+ return views::kButtonHorizontalPadding;
+ case Metric::BUTTON_MINIMUM_WIDTH:
+ return views::kMinimumButtonWidth;
sky 2017/02/24 04:15:43 Rather than exposing the constant in views could t
Peter Kasting 2017/02/24 06:32:31 I don't think we should do that in this patch set,
case Metric::DIALOG_BUTTON_MARGIN:
return views::kButtonHEdgeMarginNew;
case Metric::DIALOG_BUTTON_MINIMUM_WIDTH:
« no previous file with comments | « chrome/browser/ui/views/harmony/layout_delegate.h ('k') | ui/views/controls/button/md_text_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698