Fix the absence of padding on some UI buttons.

chrome/browser/ui/views/harmony/harmony_layout_delegate.cc

Index: chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
diff --git a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
index 45cb24b059f216a32cfa5b124dbefd104427b4c7..e61ff55c2dd57dd6d22cc842a716cca3204a5ef9 100644
--- a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
+++ b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
@@ -19,12 +19,14 @@ int HarmonyLayoutDelegate::GetMetric(Metric metric) const {
   switch (metric) {
     case Metric::BUTTON_HORIZONTAL_PADDING:
       return kHarmonyLayoutUnit;
-    case Metric::DIALOG_BUTTON_MARGIN:
-      return kHarmonyLayoutUnit;
-    case Metric::DIALOG_BUTTON_MINIMUM_WIDTH:
+    case Metric::BUTTON_MINIMUM_WIDTH:
       // Minimum label size plus padding.
       return 2 * kHarmonyLayoutUnit +
              2 * GetMetric(Metric::BUTTON_HORIZONTAL_PADDING);
+    case Metric::DIALOG_BUTTON_MARGIN:
+      return kHarmonyLayoutUnit;
+    case Metric::DIALOG_BUTTON_MINIMUM_WIDTH:
+      return GetMetric(Metric::BUTTON_MINIMUM_WIDTH);

[Peter Kasting, 2017/02/24 02:00:50]

Nit: Honestly I'd find it a bit clearer to do

  case Metric::BUTTON_MINIMUM_WIDTH:
  case Metric::DIALOG_BUTTON_MINIMUM_WIDTH:
    ...

Though this kind of implies that we should do similar things below:

  case Metric::BUTTON_HORIZONTAL_PADDING:
  case Metric::DIALOG_BUTTON_MARGIN:
  case Metric::DIALOG_BUTTON_TOP_SPACING:
  ...:
    return kHarmonyLayoutUnit;

...which honestly maybe we should, since that will make it clearer post-Harmony
what enum values we could consider removing entirely.

[Bret, 2017/02/24 02:29:45]

Done, just for BUTTON_MINIMUM_WIDTH. I'll let Allen finish refactoring before I
move all the constants around.

     case Metric::DIALOG_BUTTON_TOP_SPACING:
       return kHarmonyLayoutUnit;
     case Metric::DIALOG_CLOSE_BUTTON_MARGIN: