Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gl/gl_surface.h

Issue 2702403009: Make surface GetFormat pure virtual, add missing overrides. (Closed)
Patch Set: Add mac specific overrides Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« android_webview/browser/aw_gl_surface.cc ('K') | « gpu/ipc/service/image_transport_surface_overlay_mac.mm ('k') | ui/gl/gl_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_surface.h
diff --git a/ui/gl/gl_surface.h b/ui/gl/gl_surface.h
index 270e0ca9b263f31840448447cd368d62e8a39440..fec580ba8e0a5014f934f25380d32483a6396f39 100644
--- a/ui/gl/gl_surface.h
+++ b/ui/gl/gl_surface.h
@@ -157,8 +157,10 @@ class GL_EXPORT GLSurface : public base::RefCounted<GLSurface> {
// with this GLSurface.
virtual unsigned long GetCompatibilityKey();
- // Get the GL pixel format of the surface, if available.
- virtual GLSurfaceFormat GetFormat();
+ // Get the GL pixel format of the surface. Must be implemented in a
+ // subclass, though it's ok to just "return GLSurfaceFormat()" if
+ // the default is appropriate.
+ virtual GLSurfaceFormat GetFormat() = 0;
// Get access to a helper providing time of recent refresh and period
// of screen refresh. If unavailable, returns NULL.
« android_webview/browser/aw_gl_surface.cc ('K') | « gpu/ipc/service/image_transport_surface_overlay_mac.mm ('k') | ui/gl/gl_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698