Chromium Code Reviews| Index: ui/file_manager/gallery/js/gallery.js |
| diff --git a/ui/file_manager/gallery/js/gallery.js b/ui/file_manager/gallery/js/gallery.js |
| index 71aaac3f29b6d6f0f97e38adffc690418a099a4f..ca01de58b88b5e0d1fa22244b8afa577a6c4a48f 100644 |
| --- a/ui/file_manager/gallery/js/gallery.js |
| +++ b/ui/file_manager/gallery/js/gallery.js |
| @@ -229,40 +229,20 @@ function Gallery(volumeManager) { |
| /** |
| * First time tools fade-out timeout in milliseconds. |
| - * @const |
| - * @type {number} |
| + * @const {number} |
| + * @private |
|
fukino
2017/02/24 05:06:48
Drop @private (or append _ to the constant name)
|
| */ |
| Gallery.FIRST_FADE_TIMEOUT = 1000; |
| /** |
| * Time until mosaic is initialized in the background. Used to make gallery |
| * in the slide mode load faster. In milliseconds. |
| - * @const |
| - * @type {number} |
| + * @const {number} |
| + * @private |
|
fukino
2017/02/24 05:06:48
ditto
|
| */ |
| Gallery.MOSAIC_BACKGROUND_INIT_DELAY = 1000; |
| /** |
| - * Modes in Gallery. |
| - * @enum {string} |
| - */ |
| -Gallery.Mode = { |
| - SLIDE: 'slide', |
| - THUMBNAIL: 'thumbnail' |
| -}; |
| - |
| -/** |
| - * Sub modes in Gallery. |
| - * @enum {string} |
| - * TODO(yawano): Remove sub modes by extracting them as modes. |
| - */ |
| -Gallery.SubMode = { |
| - BROWSE: 'browse', |
| - EDIT: 'edit', |
| - SLIDESHOW: 'slideshow' |
| -}; |
| - |
| -/** |
| * Updates attributes of container element when accessibility configuration has |
| * been changed. |
| * @param {string} name |
| @@ -446,14 +426,14 @@ Gallery.prototype.onUserAction_ = function() { |
| /** |
| * Returns the current mode. |
| - * @return {Gallery.Mode} |
| + * @return {GalleryMode} |
| */ |
| Gallery.prototype.getCurrentMode = function() { |
| switch (/** @type {(SlideMode|ThumbnailMode)} */ (this.currentMode_)) { |
| case this.slideMode_: |
| - return Gallery.Mode.SLIDE; |
| + return GalleryMode.SLIDE; |
| case this.thumbnailMode_: |
| - return Gallery.Mode.THUMBNAIL; |
| + return GalleryMode.THUMBNAIL; |
| default: |
| assertNotReached(); |
| } |
| @@ -462,7 +442,7 @@ Gallery.prototype.getCurrentMode = function() { |
| /** |
| * Returns sub mode of current mode. If current mode is not set yet, null is |
| * returned. |
| - * @return {Gallery.SubMode} |
| + * @return {GallerySubMode} |
| */ |
| Gallery.prototype.getCurrentSubMode = function() { |
| assert(this.currentMode_); |
| @@ -935,12 +915,14 @@ Gallery.prototype.onFilenameEditBlur_ = function(event) { |
| /** |
| * Minimum width of rename field. |
| * @const {number} |
| + * @private |
|
fukino
2017/02/24 05:06:48
ditto
|
| */ |
| Gallery.MIN_WIDTH_RENAME_FIELD = 160; // px |
| /** |
| * End padding for rename field. |
| * @const {number} |
| + * @private |
|
fukino
2017/02/24 05:06:48
ditto
|
| */ |
| Gallery.END_PADDING_RENAME_FIELD = 20; // px |