third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 2702403005: debug-depth-video-with-copy-texture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2702403005: debug-depth-video-with-copy-texture (Closed)

Patch Set: update cts expectations Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index a3da846049bfe5db49feaba7ced2aecc5124e88d..7101f3c3d2f350f54b75502f75f50db998427cdd 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -637,11 +637,13 @@ bool WebGL2RenderingContextBase::canUseTexImageByGPU(

GLint internalformat,

GLenum type) {

switch (internalformat) {

- case GL_RGB565:

- case GL_RGBA4:

+#if OS(MACOSX)

+ // RGB5_A1 is not color-renderable on NVIDIA Mac, see crbug.com/676209.

case GL_RGB5_A1:

- // FIXME: ES3 limitation that CopyTexImage with sized internalformat,

- // component sizes have to match the source color format.

+#endif

+ // TODO(qiankun.miao@intel.com): in ES3, component sizes have to match the

+ // source color format for CopyTexImage with sized internalformat.

+ case GL_RGB9_E5:

return false;

default:

break;