third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc - Issue 2702403003: [layoutng] Split NGLayoutResult out of NGPhysicalFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

Issue 2702403003: [layoutng] Split NGLayoutResult out of NGPhysicalFragment (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

index c7fec0b567af2260e2c87ccbd562bfd3f398c3e6..4f9d7d92b5e358b87eee0bb78b0e904a9308990b 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

@@ -67,8 +67,8 @@ TEST_F(NGOutOfFlowLayoutPartTest, FixedInsideAbs) {

NGConstraintSpace* space =

NGConstraintSpace::CreateFromLayoutObject(*block_flow);

NGBlockNode node(block_flow);

- RefPtr<NGPhysicalFragment> fragment = node.Layout(space);

- EXPECT_EQ(fragment->OutOfFlowDescendants().size(), (size_t)2);

+ RefPtr<NGLayoutResult> result = node.Layout(space);

+ EXPECT_EQ(result->OutOfFlowDescendants().size(), (size_t)2);

// Test the final result.

Element* fixed_1 = document().getElementById("fixed1");