[ChromeOS] Expose keyboard remapping to signin screen.

chrome/browser/chromeos/preferences.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/preferences.h"
 
 #include <vector>
 
 #include "ash/autoclick/autoclick_controller.h"
 #include "ash/common/accessibility_types.h"
@@ skipping 379 matching lines @@
       prefs::kLanguageXkbAutoRepeatDelay, prefs, callback);
   xkb_auto_repeat_interval_pref_.Init(
       prefs::kLanguageXkbAutoRepeatInterval, prefs, callback);
 
   wake_on_wifi_darkconnect_.Init(prefs::kWakeOnWifiDarkConnect, prefs,
                                  callback);
 
   pref_change_registrar_.Init(prefs);
   pref_change_registrar_.Add(prefs::kResolveTimezoneByGeolocation, callback);
   pref_change_registrar_.Add(prefs::kUse24HourClock, callback);
+  pref_change_registrar_.Add(prefs::kLanguageRemapSearchKeyTo, callback);
+  pref_change_registrar_.Add(prefs::kLanguageRemapControlKeyTo, callback);
+  pref_change_registrar_.Add(prefs::kLanguageRemapAltKeyTo, callback);
+  pref_change_registrar_.Add(prefs::kLanguageRemapCapsLockKeyTo, callback);
+  pref_change_registrar_.Add(prefs::kLanguageRemapEscapeKeyTo, callback);
+  pref_change_registrar_.Add(prefs::kLanguageRemapBackspaceKeyTo, callback);
+  pref_change_registrar_.Add(prefs::kLanguageRemapDiamondKeyTo, callback);
 }
 
 void Preferences::Init(Profile* profile, const user_manager::User* user) {
   DCHECK(profile);
   DCHECK(user);
   sync_preferences::PrefServiceSyncable* prefs =
       PrefServiceSyncableFromProfile(profile);
   // This causes OnIsSyncingChanged to be called when the value of
   // PrefService::IsSyncing() changes.
   prefs->AddObserver(this);
@@ skipping 295 matching lines @@
     }
   }
 
   if (pref_name == prefs::kUse24HourClock ||
       reason != REASON_ACTIVE_USER_CHANGED) {
     const bool value = prefs_->GetBoolean(prefs::kUse24HourClock);
     user_manager::known_user::SetBooleanPref(user_->GetAccountId(),
                                              prefs::kUse24HourClock, value);
   }
 
+  if (pref_name == prefs::kLanguageRemapSearchKeyTo ||
+      reason != REASON_ACTIVE_USER_CHANGED) {
+    const int value = prefs_->GetInteger(prefs::kLanguageRemapSearchKeyTo);
+    user_manager::known_user::SetIntegerPref(
+        user_->GetAccountId(), prefs::kLanguageRemapSearchKeyTo, value);
+  }
+
+  if (pref_name == prefs::kLanguageRemapControlKeyTo ||
+      reason != REASON_ACTIVE_USER_CHANGED) {
+    const int value = prefs_->GetInteger(prefs::kLanguageRemapControlKeyTo);
+    user_manager::known_user::SetIntegerPref(
+        user_->GetAccountId(), prefs::kLanguageRemapControlKeyTo, value);
+  }
+
+  if (pref_name == prefs::kLanguageRemapAltKeyTo ||
+      reason != REASON_ACTIVE_USER_CHANGED) {
+    const int value = prefs_->GetInteger(prefs::kLanguageRemapAltKeyTo);
+    user_manager::known_user::SetIntegerPref(
+        user_->GetAccountId(), prefs::kLanguageRemapAltKeyTo, value);
+  }
+
+  if (pref_name == prefs::kLanguageRemapCapsLockKeyTo ||
+      reason != REASON_ACTIVE_USER_CHANGED) {
+    const int value = prefs_->GetInteger(prefs::kLanguageRemapCapsLockKeyTo);
+    user_manager::known_user::SetIntegerPref(
+        user_->GetAccountId(), prefs::kLanguageRemapCapsLockKeyTo, value);
+  }
+
+  if (pref_name == prefs::kLanguageRemapEscapeKeyTo ||
+      reason != REASON_ACTIVE_USER_CHANGED) {
+    const int value = prefs_->GetInteger(prefs::kLanguageRemapEscapeKeyTo);
+    user_manager::known_user::SetIntegerPref(
+        user_->GetAccountId(), prefs::kLanguageRemapEscapeKeyTo, value);
+  }
+
+  if (pref_name == prefs::kLanguageRemapBackspaceKeyTo ||
+      reason != REASON_ACTIVE_USER_CHANGED) {
+    const int value = prefs_->GetInteger(prefs::kLanguageRemapBackspaceKeyTo);
+    user_manager::known_user::SetIntegerPref(
+        user_->GetAccountId(), prefs::kLanguageRemapBackspaceKeyTo, value);
+  }
+
+  if (pref_name == prefs::kLanguageRemapDiamondKeyTo ||
+      reason != REASON_ACTIVE_USER_CHANGED) {
+    const int value = prefs_->GetInteger(prefs::kLanguageRemapDiamondKeyTo);
+    user_manager::known_user::SetIntegerPref(
+        user_->GetAccountId(), prefs::kLanguageRemapDiamondKeyTo, value);
+  }

[xiyuan, 2017/02/22 18:50:58]

Can we use a list and a loop instead?

e.g.

const char* const kLanguageRemapPrefs[] = {
  prefs::kLanguageRemapSearchKeyTo,
  ...
};

for (auto remap_pref : kLanguageRemapPrefs) {
  if (pref_name == remap_pref ||
      reason != REASON_ACTIVE_USER_CHANGED) {
   ...
  }
}

[xdai1, 2017/02/22 19:26:30]

Done.

+
   system::InputDeviceSettings::Get()->UpdateTouchDevicesStatusFromPrefs();
 }
 
 void Preferences::OnIsSyncingChanged() {
   DVLOG(1) << "OnIsSyncingChanged";
   ForceNaturalScrollDefault();
 }
 
 void Preferences::ForceNaturalScrollDefault() {
   DVLOG(1) << "ForceNaturalScrollDefault";
@@ skipping 81 matching lines @@
   touch_hud_projection_enabled_.SetValue(enabled);
 }
 
 void Preferences::ActiveUserChanged(const user_manager::User* active_user) {
   if (active_user != user_)
     return;
   ApplyPreferences(REASON_ACTIVE_USER_CHANGED, "");
 }
 
 }  // namespace chromeos