Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Issue 2702393003: [ChromeOS] Expose keyboard remapping to signin screen. (Closed)
Patch Set: Address alemate@'s comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_SIGNIN_SCREEN_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_SIGNIN_SCREEN_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_SIGNIN_SCREEN_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_SIGNIN_SCREEN_HANDLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 OobeScreen new_screen) override; 263 OobeScreen new_screen) override;
264 264
265 void SetFocusPODCallbackForTesting(base::Closure callback); 265 void SetFocusPODCallbackForTesting(base::Closure callback);
266 266
267 // To avoid spurious error messages on flaky networks, the offline message is 267 // To avoid spurious error messages on flaky networks, the offline message is
268 // only shown if the network is offline for a threshold number of seconds. 268 // only shown if the network is offline for a threshold number of seconds.
269 // This method reduces the threshold to zero, allowing the offline message to 269 // This method reduces the threshold to zero, allowing the offline message to
270 // show instantaneously in tests. 270 // show instantaneously in tests.
271 void ZeroOfflineTimeoutForTesting(); 271 void ZeroOfflineTimeoutForTesting();
272 272
273 const AccountId& focused_pod_account_id() {
xiyuan 2017/02/22 17:40:18 nit: Make it a const method i.e. const AccountId
xdai1 2017/02/22 18:36:16 Removed this function according to alemate@'s sugg
274 return *focused_pod_account_id_.get();
xiyuan 2017/02/22 17:40:18 What if |focused_pod_account_id_| holds nullptr an
275 }
276
273 private: 277 private:
274 enum UIState { 278 enum UIState {
275 UI_STATE_UNKNOWN = 0, 279 UI_STATE_UNKNOWN = 0,
276 UI_STATE_GAIA_SIGNIN, 280 UI_STATE_GAIA_SIGNIN,
277 UI_STATE_ACCOUNT_PICKER, 281 UI_STATE_ACCOUNT_PICKER,
278 }; 282 };
279 283
280 friend class GaiaScreenHandler; 284 friend class GaiaScreenHandler;
281 friend class ReportDnsCacheClearedOnUIThread; 285 friend class ReportDnsCacheClearedOnUIThread;
282 friend class SupervisedUserCreationScreenHandler; 286 friend class SupervisedUserCreationScreenHandler;
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 std::unique_ptr<AccountId> focused_pod_account_id_; 534 std::unique_ptr<AccountId> focused_pod_account_id_;
531 535
532 base::WeakPtrFactory<SigninScreenHandler> weak_factory_; 536 base::WeakPtrFactory<SigninScreenHandler> weak_factory_;
533 537
534 DISALLOW_COPY_AND_ASSIGN(SigninScreenHandler); 538 DISALLOW_COPY_AND_ASSIGN(SigninScreenHandler);
535 }; 539 };
536 540
537 } // namespace chromeos 541 } // namespace chromeos
538 542
539 #endif // CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_SIGNIN_SCREEN_HANDLER_H_ 543 #endif // CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_SIGNIN_SCREEN_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698