Share precompiled header setup for blink between Windows and Mac.

third_party/WebKit/Source/BUILD.gn

Index: third_party/WebKit/Source/BUILD.gn
diff --git a/third_party/WebKit/Source/BUILD.gn b/third_party/WebKit/Source/BUILD.gn
index ca5d37ceb669962f2b942391e9c90c4b2f0c26aa..99becdc560eb58fd950449393575316c0b59e130 100644
--- a/third_party/WebKit/Source/BUILD.gn
+++ b/third_party/WebKit/Source/BUILD.gn
@@ -69,6 +69,9 @@ config("blink_pch") {
 
       # Force include the header.
       cflags = [ "/FI$precompiled_header" ]
+    } else if (is_mac) {
+      precompiled_header = rebase_path("build/mac/Prefix.h", root_build_dir)

[Nico, 2017/03/03 16:04:35]

I don't think you need the rebase_path call here. Maybe try removing it and see
if that hurts. (I'm aware you're just moving this around)

(`gn help precompiled_header` is pretty confusing though, I read through gn's
code to understand how this is used)

[Nico, 2017/03/03 19:28:38]

Looking at this more, maybe precompiled_header isn't used at all with gcc-style
pchs -- does removing this line completely make any difference?

[Nico, 2017/03/03 20:30:31]

I think you can in fact remove this line.
https://codereview.chromium.org/2734523002/
https://codereview.chromium.org/2731753003/

+      precompiled_source = "//third_party/WebKit/Source/build/mac/Prefix.h"
     }
   }
 }
@@ -163,11 +166,3 @@ config("non_test_config") {
     cflags += [ "-Wglobal-constructors" ]
   }
 }
-
-if (is_mac) {
-  # This sets up precompiled headers for Mac.
-  config("mac_precompiled_headers") {
-    precompiled_header = rebase_path("build/mac/Prefix.h", root_build_dir)
-    precompiled_source = "//third_party/WebKit/Source/build/mac/Prefix.h"
-  }
-}