Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.h

Issue 2702273004: bindings: Simplifies WindowProxyManager and its relation to Frame. (Closed)
Patch Set: Fixed WindowProxyManager::createWindowProxy(ForFrame). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RemoteFrame.h
diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.h b/third_party/WebKit/Source/core/frame/RemoteFrame.h
index 4c108d0d55c0d6a6f9dd7565284d9a07eb2c2e80..27ec1189ecc9d6e67d4aaaeae77afc4b115273f8 100644
--- a/third_party/WebKit/Source/core/frame/RemoteFrame.h
+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.h
@@ -16,7 +16,6 @@ class Event;
class LocalFrame;
class RemoteFrameClient;
class RemoteFrameView;
-class RemoteWindowProxyManager;
class WebLayer;
struct FrameLoadRequest;
@@ -28,7 +27,6 @@ class CORE_EXPORT RemoteFrame final : public Frame {
// Frame overrides:
DECLARE_VIRTUAL_TRACE();
- WindowProxy* windowProxy(DOMWrapperWorld&) override;
void navigate(Document& originDocument,
const KURL&,
bool replaceCurrentItem,
@@ -61,9 +59,6 @@ class CORE_EXPORT RemoteFrame final : public Frame {
private:
RemoteFrame(RemoteFrameClient*, FrameHost*, FrameOwner*);
- // Internal Frame helper overrides:
- WindowProxyManagerBase* getWindowProxyManager() const override;
-
// Intentionally private to prevent redundant checks when the type is
// already RemoteFrame.
bool isLocalFrame() const override { return false; }
@@ -73,7 +68,6 @@ class CORE_EXPORT RemoteFrame final : public Frame {
Member<RemoteFrameView> m_view;
Member<RemoteSecurityContext> m_securityContext;
- Member<RemoteWindowProxyManager> m_windowProxyManager;
WebLayer* m_webLayer = nullptr;
};

Powered by Google App Engine
This is Rietveld 408576698