third_party/WebKit/Source/core/frame/LocalFrame.h - Issue 2702273004: bindings: Simplifies WindowProxyManager and its relation to Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2702273004: bindings: Simplifies WindowProxyManager and its relation to Frame. (Closed)

Patch Set: Fixed WindowProxyManager::createWindowProxy(ForFrame). Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.h

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h

index da489be69d7225e125b14e155c80f18b26159259..985d1e9524c3da78cc730dd0799fe99bb36dce5f 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.h

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h

@@ -107,7 +107,6 @@ class CORE_EXPORT LocalFrame final : public Frame,

// Frame overrides:

~LocalFrame() override;

DECLARE_VIRTUAL_TRACE();

- WindowProxy* windowProxy(DOMWrapperWorld&) override;

void navigate(Document& originDocument,

const KURL&,

bool replaceCurrentItem,

@@ -232,8 +231,6 @@ class CORE_EXPORT LocalFrame final : public Frame,

InterfaceProvider*,

InterfaceRegistry*);

- // Internal Frame helper overrides:

- WindowProxyManagerBase* getWindowProxyManager() const override;

// Intentionally private to prevent redundant checks when the type is

// already LocalFrame.

bool isLocalFrame() const override { return true; }