Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 2702273004: bindings: Simplifies WindowProxyManager and its relation to Frame. (Closed)
Patch Set: Fixed WindowProxyManager::createWindowProxy(ForFrame). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index fa508985fa6c43ec571df7a8a8784f2d5aea9b72..82fd77835f87734be95229e60604b5a0b23cdd9c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -33,21 +33,13 @@
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/ScriptSourceCode.h"
-#include "bindings/core/v8/ScriptValue.h"
#include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/V8Event.h"
#include "bindings/core/v8/V8GCController.h"
-#include "bindings/core/v8/V8HTMLElement.h"
-#include "bindings/core/v8/V8PerContextData.h"
#include "bindings/core/v8/V8ScriptRunner.h"
-#include "bindings/core/v8/V8Window.h"
#include "bindings/core/v8/WindowProxy.h"
#include "core/dom/Document.h"
-#include "core/dom/Node.h"
#include "core/dom/ScriptableDocumentParser.h"
-#include "core/events/Event.h"
-#include "core/events/EventListener.h"
-#include "core/frame/LocalDOMWindow.h"
+#include "core/frame/LocalFrame.h"
#include "core/frame/LocalFrameClient.h"
#include "core/frame/Settings.h"
#include "core/frame/UseCounter.h"
@@ -67,20 +59,16 @@
#include "platform/UserGestureIndicator.h"
#include "platform/instrumentation/tracing/TraceEvent.h"
#include "platform/weborigin/SecurityOrigin.h"
-#include "public/platform/Platform.h"
#include "wtf/CurrentTime.h"
#include "wtf/StdLibExtras.h"
#include "wtf/StringExtras.h"
#include "wtf/text/CString.h"
#include "wtf/text/StringBuilder.h"
-#include "wtf/text/TextPosition.h"
namespace blink {
-ScriptController::ScriptController(LocalFrame* frame)
- : m_windowProxyManager(LocalWindowProxyManager::create(*frame)) {}
-
DEFINE_TRACE(ScriptController) {
+ visitor->trace(m_frame);
visitor->trace(m_windowProxyManager);
}
@@ -153,12 +141,6 @@ v8::Local<v8::Value> ScriptController::executeScriptAndReturnValue(
return result;
}
-LocalWindowProxy* ScriptController::windowProxy(DOMWrapperWorld& world) {
- LocalWindowProxy* windowProxy = m_windowProxyManager->windowProxy(world);
- windowProxy->initializeIfNeeded();
- return windowProxy;
-}
-
bool ScriptController::shouldBypassMainWorldCSP() {
v8::HandleScope handleScope(isolate());
v8::Local<v8::Context> context = isolate()->GetCurrentContext();
@@ -180,7 +162,8 @@ TextPosition ScriptController::eventHandlerPosition() const {
void ScriptController::enableEval() {
v8::HandleScope handleScope(isolate());
v8::Local<v8::Context> v8Context =
- m_windowProxyManager->mainWorldProxy()->contextIfInitialized();
+ m_windowProxyManager->mainWorldProxyMaybeUninitialized()
+ ->contextIfInitialized();
if (v8Context.IsEmpty())
return;
v8Context->AllowCodeGenerationFromStrings(true);
@@ -189,7 +172,8 @@ void ScriptController::enableEval() {
void ScriptController::disableEval(const String& errorMessage) {
v8::HandleScope handleScope(isolate());
v8::Local<v8::Context> v8Context =
- m_windowProxyManager->mainWorldProxy()->contextIfInitialized();
+ m_windowProxyManager->mainWorldProxyMaybeUninitialized()
+ ->contextIfInitialized();
if (v8Context.IsEmpty())
return;
v8Context->AllowCodeGenerationFromStrings(false);
@@ -237,7 +221,7 @@ void ScriptController::clearWindowProxy() {
}
void ScriptController::updateDocument() {
- m_windowProxyManager->mainWorldProxy()->updateDocument();
+ m_windowProxyManager->mainWorldProxyMaybeUninitialized()->updateDocument();
}
bool ScriptController::executeScriptIfJavaScriptURL(const KURL& url,

Powered by Google App Engine
This is Rietveld 408576698