third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp - Issue 2702273004: bindings: Simplifies WindowProxyManager and its relation to Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 2702273004: bindings: Simplifies WindowProxyManager and its relation to Frame. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

index 2f3ed9fc2b99442aec45b92025575b18201427fa..393944af653800f3970736a084ccd9030fb4f656 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

@@ -980,8 +980,8 @@ v8::Isolate* toIsolate(ExecutionContext* context) {

}

v8::Isolate* toIsolate(LocalFrame* frame) {

- ASSERT(frame);

- return frame->script().isolate();

+ DCHECK(frame);

+ return frame->getWindowProxyManager()->isolate();

}

v8::Local<v8::Value> freezeV8Object(v8::Local<v8::Value> value,