bindings: Simplifies WindowProxyManager and its relation to Frame.

third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/WindowProxyManager.h"
 
 #include "bindings/core/v8/DOMWrapperWorld.h"
 
 namespace blink {
 
 namespace {
 
 WindowProxy* createWindowProxyForFrame(v8::Isolate* isolate,
                                        Frame& frame,
-
                                        RefPtr<DOMWrapperWorld> world) {
   if (frame.isLocalFrame()) {
     return LocalWindowProxy::create(isolate, toLocalFrame(frame),
                                     std::move(world));
   }
   return RemoteWindowProxy::create(isolate, toRemoteFrame(frame),
                                    std::move(world));
 }
 }
 
-DEFINE_TRACE(WindowProxyManagerBase) {
+DEFINE_TRACE(WindowProxyManager) {
   visitor->trace(m_frame);
   visitor->trace(m_windowProxy);
   visitor->trace(m_isolatedWorlds);
 }
 
-WindowProxy* WindowProxyManagerBase::windowProxy(DOMWrapperWorld& world) {
-  WindowProxy* windowProxy = nullptr;
-  if (world.isMainWorld()) {
-    windowProxy = m_windowProxy.get();
-  } else {
-    IsolatedWorldMap::iterator iter = m_isolatedWorlds.find(world.worldId());
-    if (iter != m_isolatedWorlds.end()) {
-      windowProxy = iter->value.get();
-    } else {
-      windowProxy = createWindowProxyForFrame(m_isolate, *m_frame, &world);
-      m_isolatedWorlds.set(world.worldId(), windowProxy);
-    }
-  }
-  return windowProxy;
-}
-
-void WindowProxyManagerBase::clearForClose() {
+void WindowProxyManager::clearForClose() {
   m_windowProxy->clearForClose();
   for (auto& entry : m_isolatedWorlds)
     entry.value->clearForClose();
 }
 
-void WindowProxyManagerBase::clearForNavigation() {
+void WindowProxyManager::clearForNavigation() {
   m_windowProxy->clearForNavigation();
   for (auto& entry : m_isolatedWorlds)
     entry.value->clearForNavigation();
 }
 
-void WindowProxyManagerBase::releaseGlobals(
+void WindowProxyManager::releaseGlobals(
     HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>& map) {
   map.insert(&m_windowProxy->world(), m_windowProxy->releaseGlobal());
   for (auto& entry : m_isolatedWorlds)
     map.insert(&entry.value->world(),
                windowProxy(entry.value->world())->releaseGlobal());
 }
 
-void WindowProxyManagerBase::setGlobals(
+void WindowProxyManager::setGlobals(
     const HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>& map) {
   for (auto& entry : map)
     windowProxy(*entry.key)->setGlobal(entry.value);
 }
 
-WindowProxyManagerBase::WindowProxyManagerBase(Frame& frame)
+WindowProxyManager::WindowProxyManager(Frame& frame)
     : m_isolate(v8::Isolate::GetCurrent()),
       m_frame(&frame),
       m_windowProxy(createWindowProxyForFrame(m_isolate,
                                               frame,
                                               &DOMWrapperWorld::mainWorld())) {}
 
+WindowProxy* WindowProxyManager::windowProxyMaybeUninitialized(
+    DOMWrapperWorld& world) {
+  WindowProxy* windowProxy = nullptr;
+  if (world.isMainWorld()) {
+    windowProxy = m_windowProxy.get();
+  } else {
+    IsolatedWorldMap::iterator iter = m_isolatedWorlds.find(world.worldId());
+    if (iter != m_isolatedWorlds.end()) {
+      windowProxy = iter->value.get();
+    } else {
+      windowProxy = createWindowProxyForFrame(m_isolate, *m_frame, &world);
+      m_isolatedWorlds.set(world.worldId(), windowProxy);
+    }
+  }
+  return windowProxy;
+}
+
 void LocalWindowProxyManager::updateSecurityOrigin(
     SecurityOrigin* securityOrigin) {
-  static_cast<LocalWindowProxy*>(mainWorldProxy())
-      ->updateSecurityOrigin(securityOrigin);
+  if (isMainWorldProxyInitialized())
+    mainWorldProxy()->updateSecurityOrigin(securityOrigin);

[dcheng, 2017/02/23 19:02:36]

Hmm... updateSecurityOrigin() also checks this, so it looks a bit unusual.

Maybe m_isolatedWorlds and m_mainWorldProxy should just be protected members so
they can be accessed directly?

[Yuki, 2017/03/09 14:58:53]

Done.

   for (auto& entry : isolatedWorlds()) {
     auto* isolatedWindowProxy =
         static_cast<LocalWindowProxy*>(entry.value.get());
     SecurityOrigin* isolatedSecurityOrigin =
         isolatedWindowProxy->world().isolatedWorldSecurityOrigin();
     isolatedWindowProxy->updateSecurityOrigin(isolatedSecurityOrigin);
   }
 }
 
 }  // namespace blink