Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)
Patch Set: rebased upto r451733 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebSharedWorkerImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
index dfc21de6f498c90ef51048b6a6e16ff80f800a86..47e1ed2dff6304748a02fadadb66196a4f644d33 100644
--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
@@ -353,7 +353,7 @@ void WebSharedWorkerImpl::startWorkerContext(
void WebSharedWorkerImpl::didReceiveScriptLoaderResponse() {
InspectorInstrumentation::didReceiveScriptResponse(
- m_loadingDocument.get(), m_mainScriptLoader->identifier());
+ m_loadingDocument, m_mainScriptLoader->identifier());
m_client->selectAppCacheID(m_mainScriptLoader->appCacheID());
}
@@ -415,14 +415,14 @@ void WebSharedWorkerImpl::onScriptLoaderFinished() {
m_loaderProxy = WorkerLoaderProxy::create(this);
m_workerThread = SharedWorkerThread::create(m_name, m_loaderProxy, *this,
m_parentFrameTaskRunners.get());
- InspectorInstrumentation::scriptImported(m_loadingDocument.get(),
+ InspectorInstrumentation::scriptImported(m_loadingDocument,
m_mainScriptLoader->identifier(),
m_mainScriptLoader->script());
m_mainScriptLoader.clear();
workerThread()->start(std::move(startupData));
- m_workerInspectorProxy->workerThreadCreated(
- toDocument(m_loadingDocument.get()), workerThread(), m_url);
+ m_workerInspectorProxy->workerThreadCreated(toDocument(m_loadingDocument),
+ workerThread(), m_url);
m_client->workerScriptLoaded();
}
« no previous file with comments | « third_party/WebKit/Source/web/WebSharedWorkerImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698