third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebased upto r451733 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

index 64265f1c441c1e34e26048461af69ebcf1a27dc2..e0a9d558acb65289bea90d605e977dbd72c2c208 100644

--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

@@ -263,6 +263,8 @@ void WebEmbeddedWorkerImpl::postMessageToPageInspector(const String& message) {

void WebEmbeddedWorkerImpl::postTaskToLoader(

const WebTraceLocation& location,

std::unique_ptr<ExecutionContextTask> task) {

+ // This cross-thread operation is brittle wrt per-thread heaps,

+ // posting a task to main-thread owned objects.

m_mainThreadTaskRunners->get(TaskType::Networking)

->postTask(

BLINK_FROM_HERE,