third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebased upto r451733 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h

index a987ff3d6f26ac1f7d30254c058d8bd0e2462079..499ca1f0e8f7226d650bfc658fd00dd43637e086 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h

@@ -58,7 +58,10 @@ class MediaStreamAudioDestinationHandler final

// This Persistent doesn't make a reference cycle.

Persistent<MediaStream> m_stream;

- Persistent<MediaStreamSource> m_source;

+ // Accessed by main thread and during audio thread processing.

+ //

+ // TODO: try to avoid such access during audio thread processing.

+ CrossThreadPersistent<MediaStreamSource> m_source;

// This synchronizes dynamic changes to the channel count with

// process() to manage the mix bus.