Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)
Patch Set: rebased upto r451733 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/testing/DummyPageHolder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
index b5277c251dc515b968b5b5520710c30518550714..fdaaf3f39be0df5949ba1f944bec40d991c6f524 100644
--- a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
+++ b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
@@ -349,7 +349,8 @@ class WorkerThreadableLoaderTestHelper : public ThreadableLoaderTestHelper,
std::unique_ptr<WorkerThreadForTest> m_workerThread;
std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
- Persistent<ParentFrameTaskRunners> m_parentFrameTaskRunners;
+ // Accessed cross-thread when worker thread posts tasks to the parent.
+ CrossThreadPersistent<ParentFrameTaskRunners> m_parentFrameTaskRunners;
Checkpoint m_checkpoint;
// |m_loader| must be touched only from the worker thread only.
CrossThreadPersistent<ThreadableLoader> m_loader;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/testing/DummyPageHolder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698