third_party/WebKit/Source/modules/webaudio/OscillatorNode.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OscillatorNode.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebase fixup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/OscillatorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.h b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.h

index bc8df7236c01012999437172d2114fcdd1b1d46e..207e2dd565250a6a289343628830e162738f4f18 100644

--- a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.h

@@ -96,8 +96,9 @@ class OscillatorHandler final : public AudioScheduledSourceHandler {

AudioFloatArray m_detuneValues;

// This Persistent doesn't make a reference cycle including the owner

- // OscillatorNode.

- Persistent<PeriodicWave> m_periodicWave;

+ // OscillatorNode. It is cross-thread, as it will be accessed by the audio

+ // thread.

+ CrossThreadPersistent<PeriodicWave> m_periodicWave;

};

class OscillatorNode final : public AudioScheduledSourceNode {