third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebase fixup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h ('K') | « third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h ('k') | third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h » ('j') | third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

index 7d998904f03f97b81fd7f5beac40d0508fd9a403..5a7799129c57ca1f68760f1e735e0b0f2d55ae6b 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -70,6 +70,10 @@ MediaElementAudioSourceHandler::~MediaElementAudioSourceHandler() {

uninitialize();

}

+HTMLMediaElement* MediaElementAudioSourceHandler::mediaElement() const {

+ return m_mediaElement.get();

void MediaElementAudioSourceHandler::dispose() {

m_mediaElement->setAudioSourceNode(nullptr);

AudioHandler::dispose();