Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)
Patch Set: rebase fixup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
diff --git a/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp b/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
index a8b76da86ecebc5273b1af587f67d72806dcbae7..d60433aba6ccaffaec31474785c86d9b588a3450 100644
--- a/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
+++ b/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
@@ -9,7 +9,6 @@
#include "core/dom/ExecutionContextTask.h"
#include "core/frame/Deprecation.h"
#include "core/loader/DocumentLoader.h"
-#include "core/workers/ParentFrameTaskRunners.h"
#include "core/workers/WorkerInspectorProxy.h"
#include "core/workers/WorkerThreadStartupData.h"
#include "wtf/CurrentTime.h"
@@ -75,7 +74,8 @@ void ThreadedMessagingProxyBase::postTaskToLoader(
const WebTraceLocation& location,
std::unique_ptr<ExecutionContextTask> task) {
DCHECK(getExecutionContext()->isDocument());
- m_parentFrameTaskRunners->get(TaskType::Networking)
+ getParentFrameTaskRunners()
+ ->get(TaskType::Networking)
->postTask(BLINK_FROM_HERE,
crossThreadBind(
&ExecutionContextTask::performTaskIfContextIsValid,
@@ -115,7 +115,8 @@ void ThreadedMessagingProxyBase::workerThreadCreated() {
void ThreadedMessagingProxyBase::parentObjectDestroyed() {
DCHECK(isParentContextThread());
- m_parentFrameTaskRunners->get(TaskType::UnspecedTimer)
+ getParentFrameTaskRunners()
+ ->get(TaskType::UnspecedTimer)
->postTask(
BLINK_FROM_HERE,
WTF::bind(&ThreadedMessagingProxyBase::parentObjectDestroyedInternal,

Powered by Google App Engine
This is Rietveld 408576698