Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 2702153003: [content] Fix background color update handling in RWHVAura. (Closed)
Patch Set: rebase: employ same mechanism in RWHVMac. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
index 578e7a21df7d491b06c8e13ecf9c1364aab844a3..7502ed56011a3e153eee3574832b0e5327b9531c 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
@@ -1270,11 +1270,13 @@ TEST_F(RenderWidgetHostViewMacTest, Background) {
new MockRenderWidgetHostImpl(&delegate, process_host, routing_id);
RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false);
- EXPECT_TRUE(view->GetBackgroundOpaque());
+ EXPECT_NE(static_cast<unsigned>(SK_ColorTRANSPARENT),
+ view->background_color());
EXPECT_TRUE([view->cocoa_view() isOpaque]);
view->SetBackgroundColor(SK_ColorTRANSPARENT);
- EXPECT_FALSE(view->GetBackgroundOpaque());
+ EXPECT_EQ(static_cast<unsigned>(SK_ColorTRANSPARENT),
+ view->background_color());
EXPECT_FALSE([view->cocoa_view() isOpaque]);
const IPC::Message* set_background;
@@ -1288,7 +1290,7 @@ TEST_F(RenderWidgetHostViewMacTest, Background) {
// Try setting it back.
process_host->sink().ClearMessages();
view->SetBackgroundColor(SK_ColorWHITE);
- EXPECT_TRUE(view->GetBackgroundOpaque());
+ EXPECT_EQ(static_cast<unsigned>(SK_ColorWHITE), view->background_color());
EXPECT_TRUE([view->cocoa_view() isOpaque]);
set_background = process_host->sink().GetUniqueMessageMatching(
ViewMsg_SetBackgroundOpaque::ID);
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/public/browser/render_widget_host_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698