content/browser/renderer_host/render_widget_host_unittest.cc - Issue 2702153003: [content] Fix background color update handling in RWHVAura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_unittest.cc

Issue 2702153003: [content] Fix background color update handling in RWHVAura. (Closed)

Patch Set: add back static_casts since compile complains otherwise. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_unittest.cc

diff --git a/content/browser/renderer_host/render_widget_host_unittest.cc b/content/browser/renderer_host/render_widget_host_unittest.cc

index 439ffccedb40398ae6ee560f5d6bc3cab984af69..7e52012ce79435a62dc035c21b15a3d864ef095d 100644

--- a/content/browser/renderer_host/render_widget_host_unittest.cc

+++ b/content/browser/renderer_host/render_widget_host_unittest.cc

@@ -876,9 +876,11 @@ TEST_F(RenderWidgetHostTest, Background) {

#endif

host_->SetView(view.get());

- EXPECT_TRUE(view->GetBackgroundOpaque());

+ EXPECT_NE(static_cast<unsigned>(SK_ColorTRANSPARENT),

+ view->background_color());

view->SetBackgroundColor(SK_ColorTRANSPARENT);

- EXPECT_FALSE(view->GetBackgroundOpaque());

+ EXPECT_EQ(static_cast<unsigned>(SK_ColorTRANSPARENT),

+ view->background_color());

const IPC::Message* set_background =

process_->sink().GetUniqueMessageMatching(