Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2702153003: [content] Fix background color update handling in RWHVAura. (Closed)
Patch Set: rename, cached color, comment update. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 // Used to set the |popup_child_host_view_| on the |popup_parent_host_view_| 458 // Used to set the |popup_child_host_view_| on the |popup_parent_host_view_|
459 // and to notify the |event_handler_|. 459 // and to notify the |event_handler_|.
460 void SetPopupChild(RenderWidgetHostViewAura* popup_child_host_view); 460 void SetPopupChild(RenderWidgetHostViewAura* popup_child_host_view);
461 461
462 // Forwards a mouse event to this view's parent window delegate. 462 // Forwards a mouse event to this view's parent window delegate.
463 void ForwardMouseEventToParent(ui::MouseEvent* event); 463 void ForwardMouseEventToParent(ui::MouseEvent* event);
464 464
465 // Adds/Removes frame observer based on state. 465 // Adds/Removes frame observer based on state.
466 void UpdateNeedsBeginFramesInternal(); 466 void UpdateNeedsBeginFramesInternal();
467 467
468 // Applies background color without notifying the RenderWidget about
469 // opaqueness changes.
470 void UpdateBackgroundColorFromRenderer(SkColor color);
471
468 // The model object. 472 // The model object.
469 RenderWidgetHostImpl* const host_; 473 RenderWidgetHostImpl* const host_;
470 474
471 aura::Window* window_; 475 aura::Window* window_;
472 476
473 std::unique_ptr<DelegatedFrameHostClient> delegated_frame_host_client_; 477 std::unique_ptr<DelegatedFrameHostClient> delegated_frame_host_client_;
474 // NOTE: this may be null. 478 // NOTE: this may be null.
475 std::unique_ptr<DelegatedFrameHost> delegated_frame_host_; 479 std::unique_ptr<DelegatedFrameHost> delegated_frame_host_;
476 480
477 std::unique_ptr<WindowObserver> window_observer_; 481 std::unique_ptr<WindowObserver> window_observer_;
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 583
580 // The routing and process IDs for the last RenderWidgetHost which had a 584 // The routing and process IDs for the last RenderWidgetHost which had a
581 // TextInputState of non-NONE. 585 // TextInputState of non-NONE.
582 int32_t last_active_widget_process_id_; 586 int32_t last_active_widget_process_id_;
583 int32_t last_active_widget_routing_id_; 587 int32_t last_active_widget_routing_id_;
584 588
585 // While this is a ui::EventHandler for targetting, |event_handler_| actually 589 // While this is a ui::EventHandler for targetting, |event_handler_| actually
586 // provides an implementation, and directs events to |host_|. 590 // provides an implementation, and directs events to |host_|.
587 std::unique_ptr<RenderWidgetHostViewEventHandler> event_handler_; 591 std::unique_ptr<RenderWidgetHostViewEventHandler> event_handler_;
588 592
593 // Body background color of the underlying document.
594 SkColor cached_background_color_;
595
589 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_; 596 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_;
590 597
591 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura); 598 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura);
592 }; 599 };
593 600
594 } // namespace content 601 } // namespace content
595 602
596 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 603 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698