Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2702153003: [content] Fix background color update handling in RWHVAura. (Closed)
Patch Set: add back static_casts since compile complains otherwise. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 float current_device_scale_factor() const { 82 float current_device_scale_factor() const {
83 return current_device_scale_factor_; 83 return current_device_scale_factor_;
84 } 84 }
85 85
86 // Returns the focused RenderWidgetHost inside this |view|'s RWH. 86 // Returns the focused RenderWidgetHost inside this |view|'s RWH.
87 RenderWidgetHostImpl* GetFocusedWidget() const; 87 RenderWidgetHostImpl* GetFocusedWidget() const;
88 88
89 // RenderWidgetHostView implementation. 89 // RenderWidgetHostView implementation.
90 RenderWidgetHost* GetRenderWidgetHost() const override; 90 RenderWidgetHost* GetRenderWidgetHost() const override;
91 void SetBackgroundColor(SkColor color) override;
92 SkColor background_color() override;
93 void SetBackgroundColorToDefault() final; 91 void SetBackgroundColorToDefault() final;
94 bool GetBackgroundOpaque() override;
95 ui::TextInputClient* GetTextInputClient() override; 92 ui::TextInputClient* GetTextInputClient() override;
96 void WasUnOccluded() override {} 93 void WasUnOccluded() override {}
97 void WasOccluded() override {} 94 void WasOccluded() override {}
98 bool IsShowingContextMenu() const override; 95 bool IsShowingContextMenu() const override;
99 void SetShowingContextMenu(bool showing_menu) override; 96 void SetShowingContextMenu(bool showing_menu) override;
100 void SetIsInVR(bool is_in_vr) override; 97 void SetIsInVR(bool is_in_vr) override;
101 base::string16 GetSelectedText() override; 98 base::string16 GetSelectedText() override;
102 bool IsMouseLocked() override; 99 bool IsMouseLocked() override;
103 gfx::Size GetVisibleViewportSize() const override; 100 gfx::Size GetVisibleViewportSize() const override;
104 void SetInsets(const gfx::Insets& insets) override; 101 void SetInsets(const gfx::Insets& insets) override;
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 436
440 void NotifyObserversAboutShutdown(); 437 void NotifyObserversAboutShutdown();
441 438
442 // Is this a fullscreen view? 439 // Is this a fullscreen view?
443 bool is_fullscreen_; 440 bool is_fullscreen_;
444 441
445 // Whether this view is a popup and what kind of popup it is (select, 442 // Whether this view is a popup and what kind of popup it is (select,
446 // autofill...). 443 // autofill...).
447 blink::WebPopupType popup_type_; 444 blink::WebPopupType popup_type_;
448 445
449 // The background color of the web content.
450 SkColor background_color_;
nasko 2017/03/01 18:24:53 Why remove it from the base class and have it adde
danakj 2017/03/01 18:35:10 Because the subclass needs to change the value ret
danakj 2017/03/01 18:35:35 https://codereview.chromium.org/2702153003/#msg18
451
452 // While the mouse is locked, the cursor is hidden from the user. Mouse events 446 // While the mouse is locked, the cursor is hidden from the user. Mouse events
453 // are still generated. However, the position they report is the last known 447 // are still generated. However, the position they report is the last known
454 // mouse position just as mouse lock was entered; the movement they report 448 // mouse position just as mouse lock was entered; the movement they report
455 // indicates what the change in position of the mouse would be had it not been 449 // indicates what the change in position of the mouse would be had it not been
456 // locked. 450 // locked.
457 bool mouse_locked_; 451 bool mouse_locked_;
458 452
459 // Whether we are showing a context menu. 453 // Whether we are showing a context menu.
460 bool showing_context_menu_; 454 bool showing_context_menu_;
461 455
(...skipping 21 matching lines...) Expand all
483 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_; 477 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
484 478
485 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_; 479 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
486 480
487 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 481 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
488 }; 482 };
489 483
490 } // namespace content 484 } // namespace content
491 485
492 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 486 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698