Issue 270213007: HTMLTableElement.insertRow()'s argument default value should be -1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270213007: HTMLTableElement.insertRow()'s argument default value should be -1 (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
tkent, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

HTMLTableElement.insertRow()'s argument default value should be -1 HTMLTableElement.insertRow()'s argument default value should be -1, not 0, as per the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#htmltableelement The new behavior matches the one of Firefox 29 and IE11. R=arv@chromium.org, tkent@chromium.org TEST=fast/dom/HTMLTableElement/insertRow-default-argument.html BUG=369803 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173578

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -3 lines)			Patch
A	LayoutTests/fast/dom/HTMLTableElement/insertRow-default-argument.html	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/HTMLTableElement/insertRow-default-argument-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLTableElement.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLTableElement.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLTableElement.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/270213007/1

6 years, 7 months ago (2014-05-07 23:50:27 UTC) #5

Message was sent while issue was closed.

Change committed as 173578