Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 270213006: Oilpan: Remove unnecessary trace methods in the supplement hierarchy. (Closed)

Created:
6 years, 7 months ago by zerny-chromium
Modified:
6 years, 7 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-html_chromium.org, mvanouwerkerk+watch_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, timvolodine, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis, oilpan-reviews
Visibility:
Public.

Description

Oilpan: Remove unnecessary trace methods in the supplement hierarchy. R=tkent@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173617

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M Source/core/dom/WheelController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/imports/HTMLImportsController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 chunk +0 lines, -2 lines 1 comment Download
M Source/web/ContextFeaturesClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
zerny-chromium
6 years, 7 months ago (2014-05-07 12:21:27 UTC) #1
haraken
LGTM. https://codereview.chromium.org/270213006/diff/1/Source/modules/screen_orientation/ScreenOrientationController.h File Source/modules/screen_orientation/ScreenOrientationController.h (left): https://codereview.chromium.org/270213006/diff/1/Source/modules/screen_orientation/ScreenOrientationController.h#oldcode28 Source/modules/screen_orientation/ScreenOrientationController.h:28: virtual void trace(Visitor* visitor) OVERRIDE { DocumentSupplement::trace(visitor); } ...
6 years, 7 months ago (2014-05-07 12:22:44 UTC) #2
zerny-chromium
Thanks for the review. On 2014/05/07 12:22:44, haraken wrote: > LGTM. > > https://codereview.chromium.org/270213006/diff/1/Source/modules/screen_orientation/ScreenOrientationController.h > ...
6 years, 7 months ago (2014-05-07 12:45:29 UTC) #3
tkent
lgtm
6 years, 7 months ago (2014-05-07 13:34:09 UTC) #4
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-08 06:09:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/270213006/1
6 years, 7 months ago (2014-05-08 06:10:19 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 06:58:27 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 08:20:58 UTC) #8
Message was sent while issue was closed.
Change committed as 173617

Powered by Google App Engine
This is Rietveld 408576698