Implement Pepper PPB_VideoDecoder interface.

content/renderer/pepper/pepper_video_decoder_host.h

Index: content/renderer/pepper/pepper_video_decoder_host.h
diff --git a/content/renderer/pepper/pepper_video_decoder_host.h b/content/renderer/pepper/pepper_video_decoder_host.h
new file mode 100644
index 0000000000000000000000000000000000000000..9520156413422960cad30a20f6705a7215703029
--- /dev/null
+++ b/content/renderer/pepper/pepper_video_decoder_host.h
@@ -0,0 +1,114 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_PEPPER_PEPPER_VIDEO_DECODER_HOST_H_
+#define CONTENT_RENDERER_PEPPER_PEPPER_VIDEO_DECODER_HOST_H_
+
+#include <list>

[yzshen1, 2014/05/14 18:08:23]

This is not needed (and line 10)

[bbudge, 2014/05/14 19:35:04]

Done.

+#include <map>
+#include <queue>
+#include <vector>
+
+#include "base/basictypes.h"
+#include "base/containers/hash_tables.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
+#include "content/common/content_export.h"
+#include "gpu/command_buffer/common/mailbox.h"
+#include "media/video/video_decode_accelerator.h"
+#include "ppapi/c/pp_codecs.h"
+#include "ppapi/host/host_message_context.h"
+#include "ppapi/host/resource_host.h"
+#include "ppapi/proxy/resource_message_params.h"
+
+namespace base {
+class SharedMemory;
+}
+
+namespace content {
+
+class PPB_Graphics3D_Impl;
+class RendererPpapiHost;
+class RenderViewImpl;
+
+class CONTENT_EXPORT PepperVideoDecoderHost
+    : public ppapi::host::ResourceHost,
+      public media::VideoDecodeAccelerator::Client {
+ public:
+  PepperVideoDecoderHost(RendererPpapiHost* host,
+                         PP_Instance instance,
+                         PP_Resource resource);
+  virtual ~PepperVideoDecoderHost();
+
+ private:
+  struct PendingDecode {
+    PendingDecode(uint32_t shm_id,
+                  const ppapi::host::ReplyMessageContext& reply_context);
+    ~PendingDecode();
+
+    uint32_t shm_id_;

[yzshen1, 2014/05/14 18:08:23]

I think public struct members don't need the '_' suffix.

[bbudge, 2014/05/14 19:35:04]

I did this to avoid name collisions in ctors. But I think it's better to add '_'
to the params instead.
Done.

[yzshen1, 2014/05/14 22:58:16]

I think '_' suffix has pretty specific meaning in our codebase. Maybe we could
use in_foo as ctor name in this case?

On 2014/05/14 19:35:04, bbudge wrote:

+    ppapi::host::ReplyMessageContext reply_context_;
+  };
+
+  virtual int32_t OnResourceMessageReceived(
+      const IPC::Message& msg,
+      ppapi::host::HostMessageContext* context) OVERRIDE;
+
+  // media::VideoDecodeAccelerator::Client implementation.
+  virtual void ProvidePictureBuffers(uint32 requested_num_of_buffers,
+                                     const gfx::Size& dimensions,
+                                     uint32 texture_target) OVERRIDE;
+  virtual void DismissPictureBuffer(int32 picture_buffer_id) OVERRIDE;
+  virtual void PictureReady(const media::Picture& picture) OVERRIDE;
+  virtual void NotifyError(media::VideoDecodeAccelerator::Error error) OVERRIDE;
+  virtual void NotifyFlushDone() OVERRIDE;
+  virtual void NotifyEndOfBitstreamBuffer(int32 bitstream_buffer_id) OVERRIDE;
+  virtual void NotifyResetDone() OVERRIDE;
+
+  int32_t OnHostMsgInitialize(ppapi::host::HostMessageContext* context,
+                              ppapi::HostResource graphics_context,

[yzshen1, 2014/05/14 18:08:23]

maybe const&?

[bbudge, 2014/05/14 19:35:04]

Done.

+                              PP_VideoProfile profile,
+                              bool allow_software_fallback);
+  int32_t OnHostMsgGetShm(ppapi::host::HostMessageContext* context,
+                          uint32_t size);
+  int32_t OnHostMsgAssignTextures(ppapi::host::HostMessageContext* context,
+                                  PP_Size size,

[yzshen1, 2014/05/14 18:08:23]

const &?

[bbudge, 2014/05/14 19:35:04]

Done.

+                                  const std::vector<uint32_t>& texture_ids);
+  int32_t OnHostMsgDecode(ppapi::host::HostMessageContext* context,
+                          uint32_t shm_id,
+                          uint32_t decode_id,
+                          uint32_t size);
+  int32_t OnHostMsgRecyclePicture(ppapi::host::HostMessageContext* context,
+                                  uint32_t picture_id);
+  int32_t OnHostMsgFlush(ppapi::host::HostMessageContext* context);
+  int32_t OnHostMsgReset(ppapi::host::HostMessageContext* context);
+
+  void RequestTextures(uint32 num_textures,
+                       const gfx::Size& dimensions,
+                       uint32 texture_target);
+
+  // Non-owning pointer.
+  RendererPpapiHost* renderer_ppapi_host_;
+
+  scoped_ptr<media::VideoDecodeAccelerator> decoder_;
+
+  scoped_refptr<PPB_Graphics3D_Impl> graphics3d_;
+  ScopedVector<base::SharedMemory> shm_buffers_;
+
+  // Maps decode_id to decode reply info, for pending decode messages.
+  typedef base::hash_map<uint32_t, PendingDecode> PendingDecodeMap;
+  PendingDecodeMap pending_decodes_;
+
+  ppapi::host::ReplyMessageContext flush_reply_context_;
+  ppapi::host::ReplyMessageContext reset_reply_context_;
+
+  bool initialized_;
+
+  DISALLOW_COPY_AND_ASSIGN(PepperVideoDecoderHost);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_RENDERER_PEPPER_PEPPER_VIDEO_DECODER_HOST_H_