ppapi/api/pp_errors.idl - Issue 270213004: Implement Pepper PPB_VideoDecoder interface.

Side by Side Diff: ppapi/api/pp_errors.idl

Issue 270213004: Implement Pepper PPB_VideoDecoder interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/renderer/pepper/pepper_video_decoder_host.cc ('K') | « mojo/examples/pepper_container_app/resource_creation_impl.cc ('k') | ppapi/c/pp_errors.h » ('j') | ppapi/examples/video_decode/video_decode.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file.	3 * found in the LICENSE file.

4 */	4 */

5	5

6 /**	6 /**

7 * This file defines an enumeration of all PPAPI error codes.	7 * This file defines an enumeration of all PPAPI error codes.

8 */	8 */

9	9

10 /**	10 /**

(...skipping 160 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
171 * in use.	171 * in use.

172 */	172 */

173 PP_ERROR_ADDRESS_IN_USE = -108,	173 PP_ERROR_ADDRESS_IN_USE = -108,

174 /**	174 /**

175 * This value indicates that the message was too large for the transport.	175 * This value indicates that the message was too large for the transport.

176 */	176 */

177 PP_ERROR_MESSAGE_TOO_BIG = -109,	177 PP_ERROR_MESSAGE_TOO_BIG = -109,

178 /**	178 /**

179 * This value indicates that the host name could not be resolved.	179 * This value indicates that the host name could not be resolved.

180 */	180 */

181 PP_ERROR_NAME_NOT_RESOLVED = -110	181 PP_ERROR_NAME_NOT_RESOLVED = -110,

	182 /**

	183 * This value indicates that plugin passed bad input data to the browser.

	184 */

	185 PP_ERROR_UNREADABLE_INPUT = -111,
	dmichael (off chromium) 2014/05/08 20:27:00 Hmm, I'm a little unsure about this error code. It Hmm, I'm a little unsure about this error code. It does seem to be more info than BAD_ARGUMENT, but "unreadable input" doesn't sound right to me, either. It's "readable", it just (if I understand right) doesn't conform to the expected format. What do you think of: PP_ERROR_DATA_INVALID or PP_ERROR_CONTENT_INVALID bbudge 2014/05/14 16:40:41 I struggled with this one. My first thought was PP Show quoted text On 2014/05/08 20:27:00, dmichael wrote: > Hmm, I'm a little unsure about this error code. It does seem to be more info > than BAD_ARGUMENT, but "unreadable input" doesn't sound right to me, either. > It's "readable", it just (if I understand right) doesn't conform to the expected > format. > > What do you think of: > PP_ERROR_DATA_INVALID > or > PP_ERROR_CONTENT_INVALID I struggled with this one. My first thought was PP_ERROR_MALFORMED_INPUT but I decided to just add what was needed for this API. Your preference?
	186 /**

	187 * This value indicates that a platform failure occurred. This indicates that

	188 * the browser could not complete a valid request from the plugin.

	189 */

	190 PP_ERROR_PLATFORM_FAILED = -112
	dmichael (off chromium) 2014/05/08 20:27:00 This one makes me a little sad. We're exposing mor This one makes me a little sad. We're exposing more platform differences. But I think it's probably a good idea to add the new error, rather than hide it behing PP_ERROR_FAILED. bbudge 2014/05/14 16:40:41 Yes. I'm not adding these lightly. The existing er Show quoted text On 2014/05/08 20:27:00, dmichael wrote: > This one makes me a little sad. We're exposing more platform differences. But I > think it's probably a good idea to add the new error, rather than hide it behing > PP_ERROR_FAILED. Yes. I'm not adding these lightly. The existing error codes just don't seem appropriate for these.
182 };	191 };

183	192

OLD	NEW