Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2702103002: [ScreenOrientation] De-associate device.mojom.ScreenOrientation from legacy IPC channel.

Created:
3 years, 10 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, nasko+codewatch_chromium.org, jam, mlamouri+watch-blink_chromium.org, dglazkov+blink, blink-reviews, darin-cc_chromium.org, haraken, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ScreenOrientation] De-associate device.mojom.ScreenOrientation from legacy IPC channel. This CL - registers device.mojom.ScreenOrientation into the interface registry of every render frame host, instead of using content::WebContentsFrameBindingSet to associate with legacy IPC channel before. - removes helpers in content/renderer/screen_orientation/, lets client side(blink) connect to this interface directly by itself. - lets blink synchronize ordering between response of LockOrientation() and the legacy IPC ViewMsg_Resize. BUG=678545 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 : De-associate interface, no IPC synchronization yet #

Patch Set 2 : Synchronize response of lock success with legacy IPC ViewMsg_Resize. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -504 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_provider.h View 4 chunks +12 lines, -6 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_provider.cc View 1 6 chunks +35 lines, -14 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_provider_unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -9 lines 0 comments Download
D content/renderer/screen_orientation/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/screen_orientation/screen_orientation_dispatcher.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/renderer/screen_orientation/screen_orientation_dispatcher.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D content/renderer/screen_orientation/screen_orientation_dispatcher_browsertest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M device/screen_orientation/public/interfaces/screen_orientation.mojom View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h View 1 4 chunks +28 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp View 1 6 chunks +121 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (2 generated)
leonhsl(Using Gerrit)
3 years, 10 months ago (2017-02-20 09:38:40 UTC) #3
This CL is not completed yet, some existing tests may have compilation failure
and I also want to make some new tests to confirm some subtle cases, although
now I'm still studying around layout tests..

Even though this CL can now illustrate what I want to do based on
https://codereview.chromium.org/2688383002/, to help make the whole picture
clearer.

Powered by Google App Engine
This is Rietveld 408576698