Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 27021003: Removed fullscreen test timeouts to prevent flakiness. (Closed)

Created:
7 years, 2 months ago by rune
Modified:
7 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removed fullscreen test timeouts to prevent flakiness. Some fullscreen tests had an internal timeout of 50-100ms that would cause the tests to fail if it the browser was not able to trigger the fullscreenchange event in time. The idea is that this caused the flakiness of the tests removed from TestExpectations in this CL. At least, when reducing the timeout in the test, I was able to reproduce the failure with a debug run of the fullscreen tests. BUG=100798 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/fullscreen/exit-full-screen-iframe.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-allowed.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-legacy.html View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rune
7 years, 2 months ago (2013-10-13 20:56:14 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-10-14 02:10:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/27021003/1
7 years, 2 months ago (2013-10-14 06:53:23 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-14 07:48:47 UTC) #4
Message was sent while issue was closed.
Change committed as 159564

Powered by Google App Engine
This is Rietveld 408576698