Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 2702093002: Consistent CopyFromSurface() API, consolidated to RWHV (Closed)
Patch Set: REBASE Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.h
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h
index 3395188313c87beea099e7e6bccffd511549acce..3cde24822bd4351d9c599015de560945aea872c3 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.h
+++ b/content/browser/renderer_host/render_widget_host_view_mac.h
@@ -262,7 +262,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
gfx::NativeView GetNativeView() const override;
gfx::NativeViewAccessible GetNativeViewAccessible() override;
bool HasFocus() const override;
- bool IsSurfaceAvailableForCopy() const override;
void Show() override;
void Hide() override;
bool IsShowing() override;
@@ -290,15 +289,15 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
int error_code) override;
void Destroy() override;
void SetTooltipText(const base::string16& tooltip_text) override;
- void CopyFromCompositingSurface(const gfx::Rect& src_subrect,
- const gfx::Size& dst_size,
- const ReadbackRequestCallback& callback,
- SkColorType preferred_color_type) override;
- void CopyFromCompositingSurfaceToVideoFrame(
- const gfx::Rect& src_subrect,
- const scoped_refptr<media::VideoFrame>& target,
+ bool IsSurfaceAvailableForCopy() const override;
+ void CopyFromSurface(const gfx::Rect& src_rect,
+ const gfx::Size& output_size,
+ const ReadbackRequestCallback& callback,
+ const SkColorType color_type) override;
+ void CopyFromSurfaceToVideoFrame(
+ const gfx::Rect& src_rect,
+ scoped_refptr<media::VideoFrame> target,
const base::Callback<void(const gfx::Rect&, bool)>& callback) override;
- bool CanCopyToVideoFrame() const override;
void BeginFrameSubscription(
std::unique_ptr<RenderWidgetHostViewFrameSubscriber> subscriber) override;
void EndFrameSubscription() override;

Powered by Google App Engine
This is Rietveld 408576698