Consistent CopyFromSurface() API, consolidated to RWHV

content/public/browser/render_widget_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_
 
 #include <stdint.h>
 
 #include "base/callback.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/native_web_keyboard_event.h"
-#include "content/public/browser/readback_types.h"
 #include "content/public/common/drop_data.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_sender.h"
 #include "third_party/WebKit/public/platform/WebDragOperation.h"
 #include "third_party/WebKit/public/platform/WebGestureEvent.h"
 #include "third_party/WebKit/public/platform/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebTextDirection.h"
-#include "third_party/skia/include/core/SkImageInfo.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/surface/transport_dib.h"
 
-namespace gfx {
-class Rect;
-}
-
 namespace blink {
 class WebMouseEvent;
 class WebMouseWheelEvent;
 }
 
 namespace content {
 
 class RenderProcessHost;
 class RenderWidgetHostIterator;
 class RenderWidgetHostView;
@@ skipping 116 matching lines @@
   virtual void NotifyTextDirection() = 0;
 
   virtual void Focus() = 0;
   virtual void Blur() = 0;
 
   // Sets whether the renderer should show controls in an active state.  On all
   // platforms except mac, that's the same as focused. On mac, the frontmost
   // window will show active controls even if the focus is not in the web
   // contents, but e.g. in the omnibox.
   virtual void SetActive(bool active) = 0;
 

[ncarter (slow), 2017/03/01 18:34:26]

Really glad to see this vestigial nomenclature go: BackingStores haven't existed
in a very very long time. Thanks!

Looks like the second two paragraphs of the class comment here should probably
just be deleted; if you're updating this CL anyway feel free to delete them:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_wid...

[miu, 2017/03/01 22:18:24]

Done. PTAL at render_widget_helper.h to make sure I understood your comment
correctly. FWICT, it seems everything about "backing stores" and "DIBs" in the
class comments can be deleted.

-  // Copies the given subset of the backing store, and passes the result as a
-  // bitmap to a callback.
-  //
-  // If |src_rect| is empty, the whole contents is copied. If non empty
-  // |accelerated_dst_size| is given and accelerated compositing is active, the
-  // content is shrunk so that it fits in |accelerated_dst_size|. If
-  // |accelerated_dst_size| is larger than the content size, the content is not
-  // resized. If |accelerated_dst_size| is empty, the size copied from the
-  // source contents is used. |callback| is invoked with true on success, false
-  // otherwise, along with a SkBitmap containing the copied pixel data.
-  //
-  // NOTE: |callback| is called synchronously if the backing store is available.
-  // When accelerated compositing is active, |callback| may be called
-  // asynchronously.
-  virtual void CopyFromBackingStore(const gfx::Rect& src_rect,
-                                    const gfx::Size& accelerated_dst_size,
-                                    const ReadbackRequestCallback& callback,
-                                    const SkColorType color_type) = 0;
-  // Ensures that the view does not drop the backing store even when hidden.
-  virtual bool CanCopyFromBackingStore() = 0;
-
   // Forwards the given message to the renderer. These are called by
   // the view when it has received a message.
   virtual void ForwardMouseEvent(
       const blink::WebMouseEvent& mouse_event) = 0;
   virtual void ForwardWheelEvent(
       const blink::WebMouseWheelEvent& wheel_event) = 0;
   virtual void ForwardKeyboardEvent(
       const NativeWebKeyboardEvent& key_event) = 0;
   virtual void ForwardGestureEvent(
       const blink::WebGestureEvent& gesture_event) = 0;
@@ skipping 96 matching lines @@
   // This allows the renderer to reset some state.
   virtual void DragSourceSystemDragEnded() {};
 
   // Filters drop data before it is passed to RenderWidgetHost.
   virtual void FilterDropData(DropData* drop_data) {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_H_