Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/ChromeNotificationBuilder.java

Issue 2702023002: Migrate web notifications to ChromeNotificationBuilder (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/ChromeNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChromeNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChromeNotificationBuilder.java
index b29b7d6375d7da4afa8c44e09328f8214f9d4728..8ebcecf36785f1babfd9c36430c096e667c39a75 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChromeNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChromeNotificationBuilder.java
@@ -7,6 +7,8 @@ package org.chromium.chrome.browser.notifications;
import android.app.Notification;
import android.app.PendingIntent;
import android.graphics.Bitmap;
+import android.graphics.drawable.Icon;
+import android.widget.RemoteViews;
/**
* Abstraction over Notification.Builder and NotificationCompat.Builder interfaces.
@@ -18,13 +20,15 @@ public interface ChromeNotificationBuilder {
ChromeNotificationBuilder setContentIntent(PendingIntent contentIntent);
- ChromeNotificationBuilder setContentTitle(String title);
+ ChromeNotificationBuilder setContentTitle(CharSequence title);
- ChromeNotificationBuilder setContentText(String text);
+ ChromeNotificationBuilder setContentText(CharSequence text);
ChromeNotificationBuilder setSmallIcon(int icon);
- ChromeNotificationBuilder setTicker(String text);
+ ChromeNotificationBuilder setSmallIcon(Icon icon);
+
+ ChromeNotificationBuilder setTicker(CharSequence text);
ChromeNotificationBuilder setLocalOnly(boolean localOnly);
@@ -36,7 +40,9 @@ public interface ChromeNotificationBuilder {
ChromeNotificationBuilder setShowWhen(boolean showWhen);
- ChromeNotificationBuilder addAction(int icon, String title, PendingIntent intent);
+ ChromeNotificationBuilder addAction(int icon, CharSequence title, PendingIntent intent);
+
+ ChromeNotificationBuilder addAction(Notification.Action action);
ChromeNotificationBuilder setDeleteIntent(PendingIntent intent);
@@ -44,7 +50,7 @@ public interface ChromeNotificationBuilder {
ChromeNotificationBuilder setProgress(int max, int percentage, boolean indeterminate);
- ChromeNotificationBuilder setSubText(String text);
+ ChromeNotificationBuilder setSubText(CharSequence text);
ChromeNotificationBuilder setContentInfo(String info);
@@ -54,6 +60,20 @@ public interface ChromeNotificationBuilder {
ChromeNotificationBuilder setVibrate(long[] vibratePattern);
+ ChromeNotificationBuilder setDefaults(int defaults);
+
+ ChromeNotificationBuilder setOnlyAlertOnce(boolean onlyAlertOnce);
+
+ ChromeNotificationBuilder setPublicVersion(Notification publicNotification);
+
+ ChromeNotificationBuilder setContent(RemoteViews views);
+
+ ChromeNotificationBuilder setStyle(Notification.BigPictureStyle style);
+
+ ChromeNotificationBuilder setStyle(Notification.BigTextStyle bigTextStyle);
+
+ Notification buildWithBigContentView(RemoteViews bigView);
+
Notification buildWithBigTextStyle(String bigText);
Notification build();

Powered by Google App Engine
This is Rietveld 408576698