Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java |
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java |
index 94b138c15da4fdd46fd7dbb36414f410aa69f5d6..4d571d14afabb95992c538ce2dd3b1404a0153cc 100644 |
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java |
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java |
@@ -24,6 +24,7 @@ import org.chromium.base.ApiCompatibilityUtils; |
import org.chromium.base.VisibleForTesting; |
import org.chromium.base.metrics.RecordHistogram; |
import org.chromium.chrome.R; |
+import org.chromium.chrome.browser.ChromeApplication; |
import org.chromium.ui.base.LocalizationUtils; |
import java.util.Date; |
@@ -137,9 +138,14 @@ public class CustomNotificationBuilder extends NotificationBuilderBase { |
addActionButtons(bigView); |
configureSettingsButton(bigView); |
- // Note: this is not a NotificationCompat builder so be mindful of the |
+ // Note: under the hood this is not a NotificationCompat builder so be mindful of the |
// API level of methods you call on the builder. |
- Notification.Builder builder = new Notification.Builder(mContext); |
+ // TODO(awdf) We should probably use a Compat builder. |
nyquist
2017/02/28 07:29:09
Nit: Should there be a bug filed for this so we do
awdf
2017/02/28 18:04:11
Done.
|
+ ChromeNotificationBuilder builder = |
+ ((ChromeApplication) mContext) |
+ .createChromeNotificationBuilder(false /* preferCompat */, |
+ NotificationConstants.CATEGORY_ID_GENERAL, |
+ mContext.getString(R.string.notification_category_general)); |
builder.setTicker(mTickerText); |
builder.setContentIntent(mContentIntent); |
builder.setDeleteIntent(mDeleteIntent); |
@@ -147,7 +153,7 @@ public class CustomNotificationBuilder extends NotificationBuilderBase { |
builder.setVibrate(mVibratePattern); |
builder.setWhen(mTimestamp); |
builder.setOnlyAlertOnce(!mRenotify); |
- ApiCompatibilityUtils.setContentViewForNotificationBuilder(builder, compactView); |
+ builder.setContent(compactView); |
// Some things are duplicated in the builder to ensure the notification shows correctly on |
// Wear devices and custom lock screens. |
@@ -163,12 +169,9 @@ public class CustomNotificationBuilder extends NotificationBuilderBase { |
addActionToBuilder(builder, mSettingsAction); |
} |
setGroupOnBuilder(builder, mOrigin); |
- if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { |
- // Notification.Builder.setPublicVersion was added in Android L. |
- builder.setPublicVersion(createPublicNotification(mContext)); |
- } |
+ builder.setPublicVersion(createPublicNotification(mContext)); |
- return ApiCompatibilityUtils.notificationWithBigContentView(builder, bigView); |
+ return builder.buildWithBigContentView(bigView); |
} |
/** |