Migrate web notifications to ChromeNotificationBuilder

chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.notifications;
 
 import android.app.Notification;
 import android.content.Context;
 import android.os.Build;
 
+import org.chromium.chrome.browser.ChromeApplication;
+
 /**
  * Builds a notification using the standard Notification.BigTextStyle layout.
  */
 public class StandardNotificationBuilder extends NotificationBuilderBase {
     private final Context mContext;
 
     public StandardNotificationBuilder(Context context) {
         super(context.getResources());
         mContext = context;
     }
 
     @Override
     public Notification build() {
         // Note: this is not a NotificationCompat builder so be mindful of the
         // API level of methods you call on the builder.
-        Notification.Builder builder = new Notification.Builder(mContext);
+        // TODO(awdf) We should probably use a Compat builder.
+        ChromeNotificationBuilder builder =
+                ((ChromeApplication) mContext)

[nyquist, 2017/02/28 07:29:09]

This seems unsafe. Could you use mContext.getApplicationContext() to ensure it
is in fact the application context here?

[awdf, 2017/02/28 18:04:11]

Done. (It should already be as NPB gets application context which is passed
through, but agree this is more robust)

+                        .createChromeNotificationBuilder(false /* preferCompat */,
+                                NotificationConstants.CATEGORY_ID_GENERAL,
+                                mContext.getString(org.chromium.chrome.R.string
+                                                           .notification_category_general));
+
         builder.setContentTitle(mTitle);
         builder.setContentText(mBody);
         builder.setSubText(mOrigin);
         builder.setTicker(mTickerText);
         if (mImage != null) {
             Notification.BigPictureStyle style =
                     new Notification.BigPictureStyle().bigPicture(mImage);
             if (Build.VERSION.CODENAME.equals("N")
                     || Build.VERSION.SDK_INT > Build.VERSION_CODES.M) {
                 // Android N doesn't show content text when expanded, so duplicate body text as a
@@ skipping 20 matching lines @@
         builder.setWhen(mTimestamp);
         builder.setOnlyAlertOnce(!mRenotify);
         setGroupOnBuilder(builder, mOrigin);
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
             // Notification.Builder.setPublicVersion was added in Android L.
             builder.setPublicVersion(createPublicNotification(mContext));
         }
         return builder.build();
     }
 }