third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp - Issue 2701993002: DO NOT COMMIT: Results of running new (proposed) clang-format on Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 2701993002: DO NOT COMMIT: Results of running new (proposed) clang-format on Blink (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

index d8185db1c51537cfe28581138857e88f00b6854c..bef89dc3dca12cf42de7a61e38d2c742c3128a3e 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

@@ -198,12 +198,14 @@ void InsertParagraphSeparatorCommand::doApply(EditingState* editingState) {

Position canonicalPos =

createVisiblePosition(insertionPosition).deepEquivalent();

if (!startBlock || !startBlock->nonShadowBoundaryParentNode() ||

- isTableCell(startBlock) || isHTMLFormElement(*startBlock)

+ isTableCell(startBlock) ||

+ isHTMLFormElement(*startBlock)

// FIXME: If the node is hidden, we don't have a canonical position so we

// will do the wrong thing for tables and <hr>.

// https://bugs.webkit.org/show_bug.cgi?id=40342

- || (!canonicalPos.isNull() &&

- isDisplayInsideTable(canonicalPos.anchorNode())) ||

+ ||

+ (!canonicalPos.isNull() &&

+ isDisplayInsideTable(canonicalPos.anchorNode())) ||

(!canonicalPos.isNull() && isHTMLHRElement(*canonicalPos.anchorNode()))) {

applyCommandToComposite(InsertLineBreakCommand::create(document()),

editingState);