third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h - Issue 2701983002: Implement complete lifecycle transition for IdleSpellCheckCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h

Issue 2701983002: Implement complete lifecycle transition for IdleSpellCheckCallback (Closed)

Patch Set: Add lifecycle transition unit tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/Editor.cpp ('K') | « third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h

index b7d819b7072354e2c8798c69b45f2532f87a5819..a3c18bc09387b0bf07bbe2f39b90c17b5792706c 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h

@@ -43,7 +43,7 @@ class LocalFrame;

class SpellCheckRequester;

class TextCheckerClient;

-class SpellCheckRequest final : public TextCheckingRequest {

+class CORE_EXPORT SpellCheckRequest final : public TextCheckingRequest {

public:

static SpellCheckRequest* create(const EphemeralRange& checkingRange,

int requestNumber = 0);

@@ -79,7 +79,7 @@ class SpellCheckRequest final : public TextCheckingRequest {

int m_requestNumber;

};

-class SpellCheckRequester final

+class CORE_EXPORT SpellCheckRequester final

: public GarbageCollectedFinalized<SpellCheckRequester> {

WTF_MAKE_NONCOPYABLE(SpellCheckRequester);