Implement complete lifecycle transition for IdleSpellCheckCallback

third_party/WebKit/Source/core/editing/Editor.cpp

Index: third_party/WebKit/Source/core/editing/Editor.cpp
diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp
index 8db85385837d2b5d012c1d13cbed6a7897e8960a..009f6297b5c91df24bfd47ffa3a3ca368e21b197 100644
--- a/third_party/WebKit/Source/core/editing/Editor.cpp
+++ b/third_party/WebKit/Source/core/editing/Editor.cpp
@@ -739,6 +739,7 @@ void Editor::respondToChangedContents(const VisibleSelection& endingSelection) {
   }
 
   spellChecker().updateMarkersForWordsAffectedByEditing(true);
+  frame().setNeedsSpellChecking();

[yosin_UTC9, 2017/02/23 05:20:48]

Can we make Editor owns both SpellChecker and IdleTimeSpellCheckCallback to make
LocalFrame simple?
Or make SpellChecker to own IdleTimeSpellCheckCallback?

LocalFrame is yet another kitchen sink, we want to decompose it.

[Xiaocheng, 2017/02/23 20:46:07]

I have the feeling that editing-related classes shouldn't be owned by LocalFrame
at all -- they don't make much sense when the document is inactive. See my
comment in crbug.com/695359

It seems to be a different issue, though. If we decide to move classes, let's
move them in different patches.

[yosin_UTC9, 2017/02/24 02:10:53]

I feel it is strange that SpellChecker tells LocalFrame about spell checking. I
don't imagine LocalFrame care about spell checking.
I think IdleTimeSpellChecking is just implementation details, it should not be
expose outside SpellChecker or at most core/editing/spellcheck

BTW, it seems it is better that SpellChecker is isolate from Editor, yet another
kitchen sink. Because SpellChecker doesn't(should not) depend on Editor and
Editor should not depend on SpellChecker.

   client().respondToChangedContents();
 }
 
@@ -1681,6 +1682,7 @@ void Editor::respondToChangedSelection(
     const Position& oldSelectionStart,
     FrameSelection::SetSelectionOptions options) {
   spellChecker().respondToChangedSelection(oldSelectionStart, options);
+  frame().setNeedsSpellChecking();
   client().respondToChangedSelection(&frame(),
                                      frame()
                                          .selection()