Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2701963002: Enable DDC output to run on v8/d8 using ES6 modules (Closed)

Created:
3 years, 10 months ago by vsm
Modified:
3 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable DDC output to run on v8/d8 using ES6 modules Fixes #27309 V8 / D8 tip supports ES6 modules natively. It's a little cumbersome to set up, but hello world runs. :-) > ln -s $DDC_PATH/lib/js/es6/ddc_sdk.js ddc_sdk > dart $DDC_PATH/bin/dartdevc.dart --dart-sdk-summary $DDC_PATH/lib/sdk/ddc_sdk.sum --modules es6 -o hello hello.dart > cat > run.js import { hello } from 'hello'; hello.main(); > d8 --module run.js R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/1ec614fd7b7ccc86f39057d69b9bef2fa2f72eff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -67 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/js_names.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/module_builder.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/node_modules.js View 1 chunk +53 lines, -55 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 10 months ago (2017-02-18 00:35:17 UTC) #3
Jennifer Messerly
lgtm!!! :tada:
3 years, 10 months ago (2017-02-18 00:44:36 UTC) #4
vsm
3 years, 10 months ago (2017-02-18 00:54:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ec614fd7b7ccc86f39057d69b9bef2fa2f72eff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698