Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: ios/chrome/browser/payments/payment_items_display_view_controller.mm

Issue 2701923003: [Payment Request] Error message screen (Closed)
Patch Set: Addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/payment_items_display_view_controller.mm
diff --git a/ios/chrome/browser/payments/payment_items_display_view_controller.mm b/ios/chrome/browser/payments/payment_items_display_view_controller.mm
index 53c03ed609664a12c929bd67a72af61154a9ccd6..500527a3ef4a5b3e7f3a9e4e06ed2b78e5a7a383 100644
--- a/ios/chrome/browser/payments/payment_items_display_view_controller.mm
+++ b/ios/chrome/browser/payments/payment_items_display_view_controller.mm
@@ -23,9 +23,9 @@
#import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
#include "ui/base/l10n/l10n_util.h"
-NSString* const kPaymentItemsDisplayCollectionViewId =
- @"kPaymentItemsDisplayCollectionViewId";
-NSString* const kPaymentItemsDisplayItemId = @"kPaymentItemsDisplayItemId";
+NSString* const kPaymentItemsDisplayCollectionViewID =
+ @"kPaymentItemsDisplayCollectionViewID";
+NSString* const kPaymentItemsDisplayItemID = @"kPaymentItemsDisplayItemID";
namespace {
@@ -70,7 +70,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
[self setTitle:l10n_util::GetNSString(
IDS_IOS_PAYMENT_REQUEST_PAYMENT_ITEMS_TITLE)];
- // Set up left (return) button.
+ // Set up leading (return) button.
UIBarButtonItem* returnButton =
[ChromeIcon templateBarButtonItemWithImage:[ChromeIcon backIcon]
target:nil
@@ -79,7 +79,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
setAccessibilityLabel:l10n_util::GetNSString(IDS_ACCNAME_BACK)];
[self navigationItem].leftBarButtonItem = returnButton;
- // Set up right (pay) button.
+ // Set up trailing (pay) button.
_payButton.reset([[MDCFlatButton alloc] init]);
[_payButton
setTitle:l10n_util::GetNSString(IDS_IOS_PAYMENT_REQUEST_PAY_BUTTON)
@@ -151,7 +151,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
// Add the total entry.
PriceItem* totalItem =
[[[PriceItem alloc] initWithType:ItemTypePaymentItemTotal] autorelease];
- totalItem.accessibilityIdentifier = kPaymentItemsDisplayItemId;
+ totalItem.accessibilityIdentifier = kPaymentItemsDisplayItemID;
totalItem.item =
base::SysUTF16ToNSString(_paymentRequest->payment_details().total.label);
payments::CurrencyFormatter* currencyFormatter =
@@ -169,7 +169,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
_paymentRequest->payment_details().display_items) {
PriceItem* paymentItemItem =
[[[PriceItem alloc] initWithType:ItemTypePaymentItem] autorelease];
- paymentItemItem.accessibilityIdentifier = kPaymentItemsDisplayItemId;
+ paymentItemItem.accessibilityIdentifier = kPaymentItemsDisplayItemID;
paymentItemItem.item = base::SysUTF16ToNSString(paymentItem.label);
payments::CurrencyFormatter* currencyFormatter =
_paymentRequest->GetOrCreateCurrencyFormatter();
@@ -183,7 +183,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
- (void)viewDidLoad {
[super viewDidLoad];
self.collectionView.accessibilityIdentifier =
- kPaymentItemsDisplayCollectionViewId;
+ kPaymentItemsDisplayCollectionViewID;
// Customize collection view settings.
self.styler.cellStyle = MDCCollectionViewCellStyleCard;

Powered by Google App Engine
This is Rietveld 408576698