[Payment Request] Error message screen

ios/chrome/browser/payments/payment_request_coordinator.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/payments/payment_request_coordinator.h"
 
 #include <unordered_set>
 #include <vector>
 
 #import "base/ios/weak_nsobject.h"
 #include "base/mac/objc_property_releaser.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_client.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/browser/payments/full_card_request.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.h"
+#include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/payments/payment_request.h"
 #include "ios/chrome/browser/payments/payment_request_util.h"
 #include "ios/chrome/browser/ui/autofill/card_unmask_prompt_view_bridge.h"
+#include "ui/base/l10n/l10n_util.h"
 
 // The unmask prompt UI for Payment Request.
 class PRCardUnmaskPromptViewBridge
     : public autofill::CardUnmaskPromptViewBridge {
  public:
   explicit PRCardUnmaskPromptViewBridge(
       autofill::CardUnmaskPromptController* controller,
       UIViewController* base_view_controller)
       : autofill::CardUnmaskPromptViewBridge(controller),
         base_view_controller_(base_view_controller){};
@@ skipping 72 matching lines @@
   UIViewController* base_view_controller_;  // Weak.
   autofill::CardUnmaskPromptControllerImpl unmask_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(FullCardRequester);
 };
 
 @interface PaymentRequestCoordinator () {
   base::WeakNSProtocol<id<PaymentRequestCoordinatorDelegate>> _delegate;
   base::scoped_nsobject<UINavigationController> _navigationController;
   base::scoped_nsobject<PaymentRequestViewController> _viewController;
+  base::scoped_nsobject<PaymentRequestErrorCoordinator> _errorCoordinator;
   base::scoped_nsobject<PaymentItemsDisplayCoordinator>
       _itemsDisplayCoordinator;
   base::scoped_nsobject<ShippingAddressSelectionCoordinator>
       _shippingAddressSelectionCoordinator;
   base::scoped_nsobject<ShippingOptionSelectionCoordinator>
       _shippingOptionSelectionCoordinator;
   base::scoped_nsobject<PaymentMethodSelectionCoordinator>
       _methodSelectionCoordinator;
 
   // Receiver of the full credit card details. Also displays the unmask prompt
@@ skipping 53 matching lines @@
 }
 
 - (void)stop {
   [[_navigationController presentingViewController]
       dismissViewControllerAnimated:YES
                          completion:nil];
   _itemsDisplayCoordinator.reset();
   _shippingAddressSelectionCoordinator.reset();
   _shippingOptionSelectionCoordinator.reset();
   _methodSelectionCoordinator.reset();
+  _errorCoordinator.reset();
+  _viewController.reset();
   _navigationController.reset();
-  _viewController.reset();
 }
 
 - (void)sendPaymentResponse {
   DCHECK(_paymentRequest->selected_credit_card());
   autofill::CreditCard* card = _paymentRequest->selected_credit_card();
   _fullCardRequester = base::MakeUnique<FullCardRequester>(
       self, _navigationController, _browserState);
   _fullCardRequester->GetFullCard(card, _autofillManager);
 }
 
@@ skipping 59 matching lines @@
       // view. The updated selection is already reflected in |_paymentRequest|.
       [_viewController updateSelectedShippingOptionUI];
 
       // Dismiss the shipping option selection view.
       [_shippingOptionSelectionCoordinator stop];
       _shippingOptionSelectionCoordinator.reset();
     }
   }
 }
 
+- (void)displayErrorWithCallback:(void (^)())callback {
+  _errorCoordinator.reset([[PaymentRequestErrorCoordinator alloc]
+      initWithBaseViewController:_navigationController]);
+  [_errorCoordinator setCallback:callback];
+  [_errorCoordinator setDelegate:self];
+
+  [_errorCoordinator start];
+}
+
 #pragma mark - PaymentRequestViewControllerDelegate
 
 - (void)paymentRequestViewControllerDidCancel:
     (PaymentRequestViewController*)controller {
   [_delegate paymentRequestCoordinatorDidCancel:self];
 }
 
 - (void)paymentRequestViewControllerDidConfirm:
     (PaymentRequestViewController*)controller {
   [self sendPaymentResponse];
@@ skipping 34 matching lines @@
 - (void)paymentRequestViewControllerDidSelectPaymentMethodItem:
     (PaymentRequestViewController*)controller {
   _methodSelectionCoordinator.reset([[PaymentMethodSelectionCoordinator alloc]
       initWithBaseViewController:_viewController]);
   [_methodSelectionCoordinator setPaymentRequest:_paymentRequest];
   [_methodSelectionCoordinator setDelegate:self];
 
   [_methodSelectionCoordinator start];
 }
 
+#pragma mark - PaymentRequestErrorCoordinatorDelegate
+
+- (void)paymentRequestErrorCoordinatorDidDismiss:
+    (PaymentRequestErrorCoordinator*)coordinator {
+  void (^callback)() = coordinator.callback;

[lpromero, 2017/02/21 16:51:07]

Nit: Use ProceduralBlock.

[Moe, 2017/02/21 22:56:14]

Just to make sure, since the callback gets deallocated once
_errorCoordinator.reset() is called, does it make sense to do something like the
following here:

ProceduralBlock callback = [[coordinator.callback copy] autorelease]; 

[Moe, 2017/02/21 22:56:14]

Done.

[lpromero, 2017/02/22 13:31:44]

Interesting question. If you were using ARC, line 347 would be a strong ref to
the block so it wouldn't get dealloced on line 350.
Since this is non-ARC, though, you are correct that the block can be deallocated
as is. Bug!

Use a base::mac::ScopedBlock for the local var. Good catch!

+
+  [_errorCoordinator stop];
+  _errorCoordinator.reset();
+
+  if (callback)
+    callback();
+}
+
 #pragma mark - PaymentItemsDisplayCoordinatorDelegate
 
 - (void)paymentItemsDisplayCoordinatorDidReturn:
     (PaymentItemsDisplayCoordinator*)coordinator {
   // Clear the 'Updated' label on the payment summary item, if there is one.
   [_viewController updatePaymentSummaryWithTotalValueChanged:NO];
 
   [_itemsDisplayCoordinator stop];
   _itemsDisplayCoordinator.reset();
 }
@@ skipping 63 matching lines @@
 - (void)paymentMethodSelectionCoordinatorDidReturn:
     (PaymentMethodSelectionCoordinator*)coordinator {
   // Clear the 'Updated' label on the payment summary item, if there is one.
   [_viewController updatePaymentSummaryWithTotalValueChanged:NO];
 
   [_methodSelectionCoordinator stop];
   _methodSelectionCoordinator.reset();
 }
 
 @end