sdk/lib/_internal/compiler/implementation/dart_types.dart - Issue 27019003: Update check for cyclic typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_types.dart

Issue 27019003: Update check for cyclic typedefs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add positive test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/dart_types.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_types.dart b/sdk/lib/_internal/compiler/implementation/dart_types.dart

index 9fcd6c36a7d89f4dbff97ddc2e7b69bb5fb0ac3b..b7edfbf4c7f271f39092f9912bb82c642bfa7f58 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_types.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_types.dart

@@ -780,6 +780,7 @@ class TypedefType extends GenericType {

DartType unalias(Compiler compiler) {

// TODO(ahe): This should be [ensureResolved].

compiler.resolveTypedef(element);

+ element.checkCyclicReference(compiler);

DartType definition = element.alias.unalias(compiler);

TypedefType declaration = element.computeType(compiler);

return definition.subst(typeArguments, declaration.typeArguments);