content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java - Issue 2701893002: android: Remove command line from bind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 2701893002: android: Remove command line from bind (Closed)

Patch Set: fix junit test compile Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java ('k') | content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

index b17d282b5f46a57d3cc27e2b682d9744f32b3fb0..4ba03a5836cc320684e4aab22602b1f2a368edb6 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

@@ -407,14 +407,13 @@ public class ChildProcessLauncher {

private static ChildProcessConnection allocateBoundConnection(SpawnData spawnData,

boolean alwaysInForeground, ChildProcessConnection.StartCallback startCallback) {

final Context context = spawnData.context();

- final String[] commandLine = spawnData.commandLine();

final boolean inSandbox = spawnData.inSandbox();

final ChildProcessCreationParams creationParams = spawnData.getCreationParams();

ChromiumLinkerParams chromiumLinkerParams = getLinkerParamsForNewConnection();

ChildProcessConnection connection =

allocateConnection(spawnData, chromiumLinkerParams, alwaysInForeground);

if (connection != null) {

- connection.start(commandLine, startCallback);

+ connection.start(startCallback);

String packageName = creationParams != null ? creationParams.getPackageName()

: context.getPackageName();