services/shape_detection/shape_detection_service.h - Issue 2701883002: service_manager: More consistent Service lifecycle API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shape_detection/shape_detection_service.h

Issue 2701883002: service_manager: More consistent Service lifecycle API (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/shape_detection/shape_detection_service.h

diff --git a/services/shape_detection/shape_detection_service.h b/services/shape_detection/shape_detection_service.h

index b84125f707a3f844b265c15f995922a1bb85c2cd..ab7945620d7affed6bb7d8230015f77d3ce894cc 100644

--- a/services/shape_detection/shape_detection_service.h

+++ b/services/shape_detection/shape_detection_service.h

@@ -25,7 +25,6 @@ class ShapeDetectionService : public service_manager::Service {

void OnStart() override;

bool OnConnect(const service_manager::ServiceInfo& remote_info,

service_manager::InterfaceRegistry* registry) override;

- bool OnStop() override;

private:

std::unique_ptr<service_manager::ServiceContextRefFactory> ref_factory_;